Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React should be a peer dependency of @findify/react-connect #615

Open
markjaniczak opened this issue Dec 2, 2020 · 0 comments
Open

React should be a peer dependency of @findify/react-connect #615

markjaniczak opened this issue Dec 2, 2020 · 0 comments
Assignees

Comments

@markjaniczak
Copy link

The @findify/react-connect package marks React as a regular dependency and ships with it whereas it should be a peer dependency.

This package isn't usable in a project unless a yarn resolution or similar workaround is made to prevent the local copy of React being used, e.g:

"resolutions": {
    "@findify/**/react": "^17.0.0"
}

Reproduced here.

Issue explained here also.

@Bitaru Bitaru self-assigned this Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants