Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

Use correct default maxkeys size to trigger expected pagination #157

Open
LyndonArmitage opened this issue Sep 9, 2019 · 0 comments
Open

Comments

@LyndonArmitage
Copy link

Both the InMemoryProvider and FileProvider use Int.MaxValue as their default maxkeys value:

val count = maxkeys.getOrElse(Int.MaxValue)

This should be set to 1,000 as a default so it is similar to the real S3 API, otherwise you can run into situations when testing where the Mock API will return more items than a real API call would.

See documentation of AWS limit here: https://docs.aws.amazon.com/AmazonS3/latest/API/v2-RESTBucketGET.html

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant