Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some applications don't deregister protocol handlers when uninstalled #8

Open
bershanskiy opened this issue May 14, 2021 · 3 comments
Labels

Comments

@bershanskiy
Copy link

Summary

Some applications, e.g. Steam, leave behind their Windows registry records when uninstalled. Therefore user can install an application, then delete it and still have protocol registration which is picked up by the demo. Since the demo produces results which appear as false positives (reporting that an application is installed when it ctually is not), users might dismiss the demo thinking it is inaccurate. It would be nice if you could add a note or a mark (e.g., asterisk) to programs prone to false positives.

Repro steps

  1. Install Steam so that it registers protocol handler in HKEY_CLASSES_ROOT\steam.
  2. Uninstall Steam and note that the registry record is still present.
  3. Run demo and see Steam among "installed" applications.
@spalt08
Copy link
Contributor

spalt08 commented May 14, 2021

You should probably file it as a Windows bug.
The demo is designed to detect if the custom protocol is supported by the system. Fancy UI is made to make the demo less boring.

@ericlaw1979
Copy link

  • It's not a Windows "bug" that an application can leave registry entries behind on uninstall, that's just how it works.
  • /Arguably/ a browser could do work to verify that a protocol registration is still valid (by e.g. checking for the target executable before prompting) but this would be error prone for a variety of reasons, so I don't think you're likely to land such a change in browser.

So, the demo isn't "designed to detect if the custom protocol is supported by the system" but rather "designed to detect whether the browser /thinks/ the protocol is supported by something on the system."

@spalt08
Copy link
Contributor

spalt08 commented May 14, 2021

@ericlaw1979
Good points. I've jumped to conclusions, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants