chore: add cookie secret env var #755
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Aditya-PS-05
changed the title
rgmz
reviewed
Oct 24, 2024
| if (_userSettings && _userSettings.cookieSecret) { | ||
| _cookieSecret = _userSettings.cookieSecret; | ||
| if (!_cookieSecret) { | ||
| throw new Error('COOKIE_SECRET is not defined in the environment variables.'); |
There was a problem hiding this comment.
Wouldn't this never trigger because of the fallback to 'cookie secret'?
There was a problem hiding this comment.
Yeah sorry about that, I need to correct it.
src/plugin.js
Outdated
There was a problem hiding this comment.
Are there any non-whitespace changes in this file?
|
@rgmz |
|
@Aditya-PS-05 - it looks like you have a prettier or linter that doesn't align with the standard of the project? Are you able to revert non-related changes so the PR includes changes only relevant to your suggested improvement? Massively appreciate your PR and effort ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #690