From 3d2af3e860b00be2c1c9ce40dad158df55b563d1 Mon Sep 17 00:00:00 2001
From: An Phi <aphi@skidmore.edu>
Date: Fri, 14 Apr 2023 12:17:47 -0400
Subject: [PATCH] Upgraded to gitlab4j@5.2.0

---
 legend-sdlc-server-shared/pom.xml                          | 4 ----
 .../legend/sdlc/server/BaseServerJacksonJsonProvider.java  | 3 +--
 legend-sdlc-server/pom.xml                                 | 4 ----
 .../server/LegendSDLCServerForTestJacksonJsonProvider.java | 3 +--
 .../legend/sdlc/server/resources/SDLCServerClientRule.java | 4 +---
 pom.xml                                                    | 7 +------
 6 files changed, 4 insertions(+), 21 deletions(-)

diff --git a/legend-sdlc-server-shared/pom.xml b/legend-sdlc-server-shared/pom.xml
index 8b15526bcd..c3e6f7b196 100644
--- a/legend-sdlc-server-shared/pom.xml
+++ b/legend-sdlc-server-shared/pom.xml
@@ -158,10 +158,6 @@
             <groupId>com.fasterxml.jackson.jaxrs</groupId>
             <artifactId>jackson-jaxrs-json-provider</artifactId>
         </dependency>
-        <dependency>
-            <groupId>com.fasterxml.jackson.datatype</groupId>
-            <artifactId>jackson-datatype-jsr310</artifactId>
-        </dependency>
 
         <!-- TEST -->
         <dependency>
diff --git a/legend-sdlc-server-shared/src/main/java/org/finos/legend/sdlc/server/BaseServerJacksonJsonProvider.java b/legend-sdlc-server-shared/src/main/java/org/finos/legend/sdlc/server/BaseServerJacksonJsonProvider.java
index 8ebbe23543..79f17a97cd 100644
--- a/legend-sdlc-server-shared/src/main/java/org/finos/legend/sdlc/server/BaseServerJacksonJsonProvider.java
+++ b/legend-sdlc-server-shared/src/main/java/org/finos/legend/sdlc/server/BaseServerJacksonJsonProvider.java
@@ -16,7 +16,6 @@
 
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.SerializationFeature;
-import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule;
 import com.fasterxml.jackson.jaxrs.json.JacksonJsonProvider;
 
 import javax.ws.rs.ext.ContextResolver;
@@ -28,7 +27,7 @@ public class BaseServerJacksonJsonProvider extends JacksonJsonProvider implement
     public BaseServerJacksonJsonProvider()
     {
         objectMapper = new ObjectMapper();
-        objectMapper.registerModule(new JavaTimeModule());
+        objectMapper.findAndRegisterModules();
         objectMapper.configure(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS, false);
     }
 
diff --git a/legend-sdlc-server/pom.xml b/legend-sdlc-server/pom.xml
index 3783c021b3..de1e98b34a 100644
--- a/legend-sdlc-server/pom.xml
+++ b/legend-sdlc-server/pom.xml
@@ -177,10 +177,6 @@
                 </exclusion>
             </exclusions>
         </dependency>
-        <dependency>
-            <groupId>com.fasterxml.jackson.datatype</groupId>
-            <artifactId>jackson-datatype-jsr310</artifactId>
-        </dependency>
 
         <dependency>
             <groupId>com.google.inject</groupId>
diff --git a/legend-sdlc-server/src/test/java/org/finos/legend/sdlc/server/LegendSDLCServerForTestJacksonJsonProvider.java b/legend-sdlc-server/src/test/java/org/finos/legend/sdlc/server/LegendSDLCServerForTestJacksonJsonProvider.java
index 9d56bba18e..c99ce61910 100644
--- a/legend-sdlc-server/src/test/java/org/finos/legend/sdlc/server/LegendSDLCServerForTestJacksonJsonProvider.java
+++ b/legend-sdlc-server/src/test/java/org/finos/legend/sdlc/server/LegendSDLCServerForTestJacksonJsonProvider.java
@@ -16,7 +16,6 @@
 
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.SerializationFeature;
-import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule;
 import com.fasterxml.jackson.jaxrs.json.JacksonJsonProvider;
 import org.finos.legend.sdlc.domain.model.entity.Entity;
 import org.finos.legend.sdlc.domain.model.project.Project;
@@ -38,7 +37,7 @@ public class LegendSDLCServerForTestJacksonJsonProvider extends JacksonJsonProvi
     public LegendSDLCServerForTestJacksonJsonProvider()
     {
         objectMapper = new ObjectMapper();
-        objectMapper.registerModule(new JavaTimeModule());
+        objectMapper.findAndRegisterModules();
         objectMapper.disable(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS);
         objectMapper.addMixIn(Project.class, InMemoryMixins.Project.class);
         objectMapper.addMixIn(Workspace.class, InMemoryMixins.Workspace.class);
diff --git a/legend-sdlc-server/src/test/java/org/finos/legend/sdlc/server/resources/SDLCServerClientRule.java b/legend-sdlc-server/src/test/java/org/finos/legend/sdlc/server/resources/SDLCServerClientRule.java
index e134b23583..7a06fba03d 100644
--- a/legend-sdlc-server/src/test/java/org/finos/legend/sdlc/server/resources/SDLCServerClientRule.java
+++ b/legend-sdlc-server/src/test/java/org/finos/legend/sdlc/server/resources/SDLCServerClientRule.java
@@ -17,7 +17,6 @@
 import com.fasterxml.jackson.annotation.JsonInclude;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.SerializationFeature;
-import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule;
 import com.fasterxml.jackson.jaxrs.json.JacksonJsonProvider;
 import org.finos.legend.sdlc.domain.model.entity.Entity;
 import org.finos.legend.sdlc.domain.model.project.Project;
@@ -79,7 +78,7 @@ static class SDLCServerClientRuleJacksonJsonProvider extends JacksonJsonProvider
         public SDLCServerClientRuleJacksonJsonProvider()
         {
             objectMapper = new ObjectMapper();
-            objectMapper.registerModule(new JavaTimeModule());
+            this.objectMapper.findAndRegisterModules();
             this.objectMapper.enable(SerializationFeature.INDENT_OUTPUT);
             this.objectMapper.disable(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS);
             this.objectMapper.setSerializationInclusion(JsonInclude.Include.NON_NULL);
@@ -91,7 +90,6 @@ public SDLCServerClientRuleJacksonJsonProvider()
             this.objectMapper.addMixIn(ProjectRevision.class, ProjectRevisionMixin.class);
             this.objectMapper.addMixIn(ProjectDependency.class, ProjectDependencyMixin.class);
             this.objectMapper.addMixIn(VersionId.class, VersionIdMixin.class);
-            this.objectMapper.findAndRegisterModules();
         }
 
         @Override
diff --git a/pom.xml b/pom.xml
index 2f2ec089c3..a19a82c46f 100644
--- a/pom.xml
+++ b/pom.xml
@@ -82,7 +82,7 @@
         <dropwizard-swagger.version>1.3.17-1</dropwizard-swagger.version>
         <eclipsecollections.version>10.2.0</eclipsecollections.version>
         <findbugs.version>3.0.0</findbugs.version>
-        <gitlab4j.version>5.1.0</gitlab4j.version>
+        <gitlab4j.version>5.2.0</gitlab4j.version>
         <guava.version>30.0-jre</guava.version>
         <guice.version>4.2.1</guice.version>
         <h2.version>1.4.200</h2.version>
@@ -832,11 +832,6 @@
                 <version>${legend.engine.version}</version>
             </dependency>
             <!-- External dependencies -->
-            <dependency>
-                <groupId>com.fasterxml.jackson.datatype</groupId>
-                <artifactId>jackson-datatype-jsr310</artifactId>
-                <version>${jackson.version}</version>
-            </dependency>
             <dependency>
                 <groupId>com.fasterxml.jackson.core</groupId>
                 <artifactId>jackson-annotations</artifactId>