[Do not merge] Changes required for Swift 6 #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
…/firebase/data-connect-ios-sdk into peterfriese/samples/movietracker
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
…eterfriese/samples/movietracker-new-ui/main Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
…onnect' into peterfriese/samples/movietracker-new-ui/main Signed-off-by: Peter Friese <[email protected]>
…terfriese/samples/movietracker Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
Signed-off-by: Peter Friese <[email protected]>
aashishpatil-g
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
The Swift 6 changes look fine.
In 11.4.0-beta (released yesterday, Nov 12 ) there are multiple changes to support Concurrency and we also released support in the codegen module last week.
Curious, if that works without making some of these changes - specifically adding @preconcurrency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the changes required in the movie tracker sample app to make it work when compiling with Swift 6 language mode enabled.