From 16b92a045bbeb6effd0debc4fd479965312cca5c Mon Sep 17 00:00:00 2001 From: Jon Simantov Date: Wed, 11 Oct 2023 16:50:34 -0700 Subject: [PATCH 1/2] Don't run a UMP test that doesn't work on iOS simulator. --- gma/integration_test/src/integration_test.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gma/integration_test/src/integration_test.cc b/gma/integration_test/src/integration_test.cc index f09bf216d7..9c6daafdc6 100644 --- a/gma/integration_test/src/integration_test.cc +++ b/gma/integration_test/src/integration_test.cc @@ -3023,6 +3023,8 @@ TEST_F(FirebaseGmaUmpTest, TestUmpCallbacksOnWrongInstance) { TEST_F(FirebaseGmaUmpTest, TestUmpMethodsReturnOperationInProgress) { SKIP_TEST_ON_DESKTOP; + SKIP_TEST_ON_IOS_SIMULATOR; // LoadAndShowConsentFormIfRequired + // is too quick on simulator. using firebase::gma::ump::ConsentFormStatus; using firebase::gma::ump::ConsentRequestParameters; From a862124095f8e1d6c0ff3cd86cc4516f33681dc4 Mon Sep 17 00:00:00 2001 From: Jon Simantov Date: Wed, 11 Oct 2023 16:52:21 -0700 Subject: [PATCH 2/2] Format. --- gma/integration_test/src/integration_test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gma/integration_test/src/integration_test.cc b/gma/integration_test/src/integration_test.cc index 9c6daafdc6..e7bc556ced 100644 --- a/gma/integration_test/src/integration_test.cc +++ b/gma/integration_test/src/integration_test.cc @@ -3024,7 +3024,7 @@ TEST_F(FirebaseGmaUmpTest, TestUmpCallbacksOnWrongInstance) { TEST_F(FirebaseGmaUmpTest, TestUmpMethodsReturnOperationInProgress) { SKIP_TEST_ON_DESKTOP; SKIP_TEST_ON_IOS_SIMULATOR; // LoadAndShowConsentFormIfRequired - // is too quick on simulator. + // is too quick on simulator. using firebase::gma::ump::ConsentFormStatus; using firebase::gma::ump::ConsentRequestParameters;