-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App archive fails validation due to invalid plist file #12441
Comments
I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight. |
When will this release be made available? |
In the meantime, the workaround is to continue to use Xcode 15.2 or earlier. |
That's fine, it's annoying as Xcode Cloud automatically treats the RC as a "Latest release" Xcode version and has switched over. Will have to manually set it back to Xcode 15.2 for now. |
I'm using Xcode 14.2 and also getting this issue... |
I'm using Xcode 15.2 and getting this issue on all App Store Connect archives. Is there another fix for this? Is there an older version of Firebase we should use in the meantime? |
If you're having a validation problem with an Xcode other than 15.3, please open a separate issue with the template filled out describing the problem and installation method. |
Apologies, you are correct above in that it works on Xcode 15.2. In case anyone else runs into this... I did not realize Xcode Cloud archives do not use the Xcode version that is on your computer. You can set the Xcode version for Xcode Cloud builds within App Store Connect -> Xcode Cloud -> Manage Workflows -> Workflow -> Xcode version. The default value is "Latest Release" which is currently Xcode 15.3 RC. |
@cameroncooke This should now be fixed in the 10.22.0 release. Please re-open if you're still running into app validation issues. |
it is not fixed for me with 15.3, I am getting numerous 'asset validation failed' errors on distribution via archive. |
+1 |
1 similar comment
+1 |
|
Correct. Though you could argue that a package vendor is responsible for all the dependencies it brings in. Apple even sees it this way when it comes to the new privacy manifests. |
@ncooke3 is working on a fix for the errors in the dependencies in google/abseil-cpp-binary#6 and google/grpc-binary#10. |
The binary SPM distributions for Abseil, gRPC, and BoringSSL have now been updated and released. The latest version of Firebase should pick them up if you update your SPM workspace. Each of the three SDKs also now has a privacy manifest. |
waiting for an update, thanks! |
@alexanderkhitev, the binary dependencies have been released. If you're using the binary distribution of Firestore (on by default), then you can pull them in by updating your SPM workspace. |
Thanks for this. What are the new version numbers for these? I'm seeing the following version numbers in the Xcode cloud build log: Firebase: https://github.com/firebase/firebase-ios-sdk @ 10.22.0 ...and still getting the same error as above when building and validating with Xcode 15.3. Any thoughts? Thanks |
^ These should be the fixed versions. You shouldn't be seeing validation errors related to these frameworks anymore. Please let me know if you're seeing differently.
^ This one is still being worked on. |
OK, thanks. The error I'm seeing is from the GoogleAppMeasurement framework so I'll wait for this to be updated as well. |
Yeah, I'm now getting this error.
|
A fix for this should be coming out today. Binary artifacts are currently being rebuilt. Until then, a workaround should be to fall back to Xcode 15.2. |
Thank you so much. It's really urgent for me to update as soon as possible. |
Unfortunately we need to delay the patch release until tomorrow. Please continue to use Xcode 15.2 in the meantime. Sorry for the delay in getting this out. |
No problem, you are doing some great job and this is the most important. |
Getting the same issue with Payload GoogleAppMeasurementOnDeviceConversion.framework with key CFBundleShortVersionString. Looking forward to a fix :) |
Sorry again for the delay. The fixes are now released:
|
I can confirm the new 10.22.1 has resolved the Payload GoogleAppMeasurementOnDeviceConversion.framework with key CFBundleShortVersionString missing error for me. I am using xcode 15.3 Thank you Devs! |
Thanks for getting this sorted so promptly. Much appreciated. 👍🏻 |
Thanks for your patience and for confirming! |
I've bumped my Firebase version to v10.22.1, but I'm still getting build errors on Xcode Cloud using the latest release of Xcode / MacOS: The issue is with gRPC which was supposed to be fixed in v10.22.0.
Updating to latest dependencies now: TLDR: This fixes the GoogleAppMeasurement issue, but seems to have lost the fixes for gRPC and abseil. |
Thank you so much for the update. |
Hi @lenli, I'm not sure why Xcode Cloud would be handling this differently. Perhaps there is interference from a checked-in |
Not sure why but here's happened to me: |
I just ran an Xcode Cloud build using 15.3, all good here. Ensure packages are updated and the resulting Package.resolved is pushed to repo before starting build... Thanks for a quick resolution. 👍🏻 |
Yep, it worked for me now too. 👍 |
@frantischek, I would recommend deleting derived data if you haven't already. Otherwise, please file an issue on the Ads repo (https://github.com/googleads/swift-package-manager-google-mobile-ads/issues). |
To wrap up this issue's discussion,
If you run into any further issues, please open a new issue. Thanks! |
Description
When building our app for Archive using Xcode 15.3 the app fails the validation stage on App Store Connect due to problems with the framework's
Info.plist
file. Our app is targeting iOS and has a deployment target of iOS 16.It's worth noting that the same is happening for GoogleAppMeasurement (google/GoogleAppMeasurement#62) library and another 3rd party library in our project.
Reproducing the issue
Build an app using Xcode 15.3 RC that uses the Google Firebase SPM package
Firebase SDK Version
10.18.0
Xcode Version
15.3 RC
Installation Method
Swift Package Manager
Firebase Product(s)
All
Targeted Platforms
iOS
Relevant Log Output
If using Swift Package Manager, the project's Package.resolved
Expand
Package.resolved
snippetReplace this line with the contents of your Package.resolved.
If using CocoaPods, the project's Podfile.lock
Expand
Podfile.lock
snippetReplace this line with the contents of your Podfile.lock!
The text was updated successfully, but these errors were encountered: