Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly Testing Report #13211

Closed
github-actions bot opened this issue Jul 2, 2024 · 5 comments
Closed

Nightly Testing Report #13211

github-actions bot opened this issue Jul 2, 2024 · 5 comments

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Nightly Testing Report

This issue(log) is generated at 07/02/2024 05:03 AM, fetching workflow runs triggered in the last 24 hrs.

Workflow 07/01
crashlytics failure
mlmodeldownloader failure
storage failure
zip failure
@paulb777
Copy link
Member

paulb777 commented Jul 2, 2024

The zip failure looks like the tags were updated but not the MLModelDownloader podspec to SpecsStaging. I'll do that and rerun all the tests.

@ncooke3
Copy link
Member

ncooke3 commented Jul 2, 2024

The zip failure looks like the tags were updated but not the MLModelDownloader podspec to SpecsStaging. I'll do that and rerun all the tests.

Ah, so this is where the difference between what release.yml does and what testing SpecsStaging testing does. For cases like last night, release.yml passed because it staged the latest tagged version of MLModelDownloader to the FirebasePrivate/SpecsTesting repo. SpecsStaging failed because it didn't have the latest.

@ncooke3
Copy link
Member

ncooke3 commented Jul 2, 2024

An easy improvement could be to update the tagging command to automatically stage podspecs that have changed since the last tag's position. So, it's impossible to, when using our release tooling, move the CocoaPods tags without staging pods that need staging.

The next step could be running this combined tag + stage command after any PR that changes a podspec. I believe that would eliminate the need for the release.yml entirely as SpecStaging should always have the correctly tagged podspecs at the tip of main.

@ncooke3
Copy link
Member

ncooke3 commented Jul 2, 2024

We'd need some mechanism to prevent tags from being moved past key dates like code freeze (e.g. locking tag, disabling workflow until next version of pods are staged, etc.), and think through cases where there are release branches.

@paulb777
Copy link
Member

paulb777 commented Jul 2, 2024

Closing since zip succeeded.

The others look increasingly flaky and may need to be investigated.

@paulb777 paulb777 closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants