Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweaks for flaky tests #13971

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Tweaks for flaky tests #13971

merged 3 commits into from
Oct 25, 2024

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Oct 25, 2024 •
edited
Loading

Fix #13964

This seems to improve the stability of the Storage integration tests and RC watchOS test flakiness.

More investigation is still needed for the RTDB integration tests.

@paulb777 paulb777 requested a review from andrewheard October 25, 2024 16:24
andrewheard
andrewheard approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Merging now and investigating the RTDB integration tests later SGTM since they were already failing.

@paulb777 paulb777 merged commit 0f73266 into main Oct 25, 2024
80 of 81 checks passed
@paulb777 paulb777 deleted the pb-flakes branch October 25, 2024 17:05
@firebase firebase locked and limited conversation to collaborators Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewheard andrewheard andrewheard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nightly Testing Report
2 participants
@paulb777 @andrewheard