Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vertex AI] Fix deployment targets for TestApp #13973

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Oct 25, 2024

Reduced the deployment targets from iOS 17.2 / macOS 14.2 to iOS 15.0 / macOS 12.0 to match the SDK.

#no-changelog

@andrewheard andrewheard marked this pull request as ready for review October 28, 2024 14:02
@andrewheard
Copy link
Contributor Author

Thanks for the review, @paulb777! I still want figure out the test logging (in the success cases) but will go ahead and merge this since it's not dependent on that.

@andrewheard andrewheard merged commit 476c9eb into main Oct 28, 2024
39 checks passed
@andrewheard andrewheard deleted the ah/vertex-test-app branch October 28, 2024 14:04
@firebase firebase locked and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants