Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Use macos-14 for the zip build #14090

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Nov 12, 2024

We reverted back to using the much slower macos-13 runner images in #13562 because of frequent failures due to running out of disk space. This may no longer be an issue now that GitHub has limited macos-14 runners to Xcode 15.x. Testing on CI.

#no-changelog

@andrewheard andrewheard force-pushed the ah/zip-build-macos-14 branch from c1952b8 to 2c96291 Compare November 12, 2024 15:54
Base automatically changed from ah/zip-macos-15 to main November 12, 2024 21:31
@andrewheard andrewheard force-pushed the ah/zip-build-macos-14 branch from 6908f5a to a5d4966 Compare November 12, 2024 21:35
@andrewheard andrewheard marked this pull request as ready for review November 12, 2024 21:37
@andrewheard andrewheard requested a review from paulb777 November 12, 2024 21:38
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@andrewheard
Copy link
Contributor Author

LGTM on green

@paulb777 If CI is still running after the 11.6.0 pods are finished staging, would you mind if I merged this? CI was green before I rebased on main and these diffs are unlikely to be problematic. When I create the PR from https://github.com/firebase/firebase-ios-sdk/compare/version-11.6 it'll run the zip workflow and more likely to finish before the nightly tasks start on the macos-14 runner.

@andrewheard andrewheard merged commit c509259 into main Nov 13, 2024
65 checks passed
@andrewheard andrewheard deleted the ah/zip-build-macos-14 branch November 13, 2024 00:57
@firebase firebase locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants