Skip to content

Access-Control-Allow-Credentials headers not being set on localhost on 10.2.2 #4261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vpanyushenko opened this issue Mar 7, 2022 · 3 comments

Comments

@vpanyushenko
Copy link

[REQUIRED] Environment info

[email protected]

firebase-tools:10.2.2

MacOS

[REQUIRED] Test case

Running a local express server that hosts an API on port 5001. Frontend runs on port 3000. The express is correctly configured with the cors middleware which accepts localhost:5001 and localhost:3000. The request failed due to:

"Access to fetch at 'http://localhost:5001/px-platform-dev-a1ec4/us-central1/api/v1/auth/login' from origin 'http://localhost:3000' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: The value of the 'Access-Control-Allow-Credentials' header in the response is '' which must be 'true' when the request's credentials mode is 'include'."

This could have something to do with #4227 but I'm not sure.

[REQUIRED] Steps to reproduce

See above

[REQUIRED] Expected behavior

The request should pass preflight. This is not an issue with [email protected]

[REQUIRED] Actual behavior

It fails preflight so nothing get's logged to the terminal.

@yuchenshi
Copy link
Member

Would you mind posting a minimal repro of your server and maybe also HAR files? This can help us look into the headers

@yuchenshi yuchenshi added the Needs: Author Feedback Issues awaiting author feedback label Mar 7, 2022
@google-oss-bot
Copy link
Contributor

Hey @vpanyushenko. We need more information to resolve this issue but there hasn't been an update in 7 weekdays. I'm marking the issue as stale and if there are no new updates in the next 3 days I will close it automatically.

If you have more information that will help us get to the bottom of this, just add a comment!

@google-oss-bot
Copy link
Contributor

Since there haven't been any recent updates here, I am going to close this issue.

@vpanyushenko if you're still experiencing this problem and want to continue the discussion just leave a comment here and we are happy to re-open this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants