Skip to content

Still 3 references to dart:html #12597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
kevmoo opened this issue Apr 5, 2024 · 2 comments · Fixed by #12601
Closed
1 task done

Still 3 references to dart:html #12597

kevmoo opened this issue Apr 5, 2024 · 2 comments · Fixed by #12601
Assignees
Labels
Needs Attention This issue needs maintainer attention. platform: web Issues / PRs which are specifically for web. plugin: app_check plugin: core plugin: storage resolution: fixed A fix has been merged or is pending merge from a PR. type: bug Something isn't working

Comments

@kevmoo
Copy link
Collaborator

kevmoo commented Apr 5, 2024

Is there an existing issue for this?

  • I have searched the existing issues.

Which plugins are affected?

Other

Which platforms are affected?

Web

Description

> github/flutterfire git:(master) git gp 'dart:html'
packages/firebase_app_check/firebase_app_check_web/lib/firebase_app_check_web.dart:6:import 'dart:html';
packages/firebase_core/firebase_core_web/test/tools.dart:5:import 'dart:html';
packages/firebase_storage/firebase_storage/example/lib/save_as/save_as_html.dart:6:import 'dart:html';
> github/flutterfire git:(master) git gp 'dart.library'
packages/_flutterfire_internals/lib/_flutterfire_internals.dart:17:    if (dart.library.js) 'package:firebase_core_web/firebase_core_web_interop.dart'
packages/firebase_storage/firebase_storage/example/lib/save_as/save_as.dart:5:export 'save_as_interface.dart' if (dart.library.html) 'save_as_html.dart';

See #12027 (comment)

as of 1b6ef73

Reproducing the issue

Grep the source

Firebase Core version

???

Flutter Version

n/a

Relevant Log Output

No response

Flutter dependencies

Expand Flutter dependencies snippet
Replace this line with the contents of your `flutter pub deps -- --style=compact`.

Additional context and comments

No response

@kevmoo kevmoo added type: bug Something isn't working Needs Attention This issue needs maintainer attention. labels Apr 5, 2024
@Salakar Salakar added plugin: core platform: web Issues / PRs which are specifically for web. plugin: app_check plugin: storage labels Apr 5, 2024
@Lyokone Lyokone self-assigned this Apr 8, 2024
@Lyokone
Copy link
Contributor

Lyokone commented Apr 8, 2024

Sorry about that, will be fixed by #12601

@Lyokone
Copy link
Contributor

Lyokone commented Apr 8, 2024

Thanks for raising this, it will be part of next release scheduled for tomorrow

@TarekkMA TarekkMA added the resolution: fixed A fix has been merged or is pending merge from a PR. label Apr 16, 2024
@firebase firebase locked and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Needs Attention This issue needs maintainer attention. platform: web Issues / PRs which are specifically for web. plugin: app_check plugin: core plugin: storage resolution: fixed A fix has been merged or is pending merge from a PR. type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants