-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the SDK to export an actual ES2015 module #123
Comments
I'm been looking for how to integrate GeoFire to my Angular 2 project. My project is created using the angular-cli which uses webpack. Does this issue mean I can't import GeoFire right now? |
You can include it the "old-fashioned" way. That is, just include a |
You have no other way to integrate GeoFire with webpack ? Include a js file in html, with a beautiful angular2 apps, so bad... :( |
|
@firebase-ops I'm not sure if this is still an active endeavor, but I banged out this... https://github.com/MichaelSolati/geofire-js/tree/typescript I believe the next steps would be to implement the tests you guys have written already as well as some build tweaks (and a uglify/bundle). Regardless, I would love help on these next steps if anyone is interested. I'd say it's probably 75% done IMHO. |
PRs welcome!
Currently the library is exported in such a way that you can only use
require('geofire')
within Node.js. This means you cannot getrequire('geofire')
orimport * as GeoFire from 'geofire'
to work with ES2015-compatible browsers or browser bundlers like webpack and Browserify. We should export an actual ES2015 module to support those modern use-cases.The text was updated successfully, but these errors were encountered: