Update fb-unified-openapi.yaml (K.L. Oct 27th, 2025) #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added two categories, and within them, two subcategories: 1. Providers to Fireblocks APIs > Off Exchange 2. Webhooks > Collateral webhooks
yanivmo
requested changes
Oct 29, 2025
Comment on lines
+58
to
+64
| x-tagGroups: | ||
| - name: Providers to Fireblocks APIs | ||
| tags: | ||
| - Off Exchange | ||
| - name: Webhooks | ||
| tags: | ||
| - Collateral webhooks |
Collaborator
There was a problem hiding this comment.
We haven't used tag groups until now, and I wouldn't start now. Definitely not without grouping other tags too. I'd remove this.
Comment on lines
+52
to
+56
| - name: Off Exchange | ||
| description: Endpoints used by external providers (exchanges) calling Fireblocks | ||
| for off-exchange collateral flows. | ||
| - name: Collateral webhooks | ||
| description: Webhook notifications sent by Fireblocks to exchanges for collateral events. |
Collaborator
There was a problem hiding this comment.
Please, use identifier style name, like in other tags: offExchange and collateralWebhooks.
Comment on lines
+52
to
+56
| - name: Off Exchange | ||
| description: Endpoints used by external providers (exchanges) calling Fireblocks | ||
| for off-exchange collateral flows. | ||
| - name: Collateral webhooks | ||
| description: Webhook notifications sent by Fireblocks to exchanges for collateral events. |
Collaborator
There was a problem hiding this comment.
What's the point of adding tags without adding anything to these tags?
Comment on lines
+52
to
+56
| - name: Off Exchange | ||
| description: Endpoints used by external providers (exchanges) calling Fireblocks | ||
| for off-exchange collateral flows. | ||
| - name: Collateral webhooks | ||
| description: Webhook notifications sent by Fireblocks to exchanges for collateral events. |
Collaborator
There was a problem hiding this comment.
The file v2/openapi/fb-unified-openapi.yaml is autogenerated. A change like this should be made in v2/openapi/fb-provider-collateral-api.yaml and then fb-unified-openapi.yaml should be generated from it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added two categories, and within them, two subcategories: