stake_redelegate: Fix issues discovered through fuzzing #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topointon-jump
previously approved these changes
Apr 29, 2024
| @@ -159,7 +159,7 @@ | |||
| {"name":"vote_state_add_vote_latency","pubkey": "7axKe5BTYBDD87ftzWbk5DfzWMGyRvqmWTduuo22Yaqy"}, | |||
| {"name":"checked_arithmetic_in_fee_validation","pubkey": "5Pecy6ie6XGm22pc9d4P9W5c31BugcFBuy6hsP2zkETv","hardcoded":1}, | |||
| {"name":"last_restart_slot_sysvar","pubkey": "HooKD5NC9QNxk25QuzCssB8ecrEzGt6eXEPBUxWp1LaR"}, | |||
| {"name":"reduce_stake_warmup_cooldown","pubkey": "GwtDQBghCTBgmX2cpEGNPxTEBUTQRaDMGTr5qychdGMj"}, | |||
| {"name":"reduce_stake_warmup_cooldown","pubkey": "GwtDQBghCTBgmX2cpEGNPxTEBUTQRaDMGTr5qychdGMj","hardcoded":1}, | |||
There was a problem hiding this comment.
There is still one usage of this feature in agave/sdk/src/feature_set.rs - anza-xyz/agave#470, which is used indirectly by the stake program.
I think in this case it is fine to treat this feature as hardcoded, however, as the feature account will still exist in mainnet/testnet ledgers.
| .distributed_rewards = distributed_rewards, | ||
| .total_rewards = total_rewards, | ||
| .distribution_complete_block_height = distribution_complete_block_height | ||
| // THIS IS ALL WRONG... this needs to be fixed for how epoch rewards have been rewritten |
There was a problem hiding this comment.
Could you add a comment at the top of this file clarifying that this is still potentially a WIP and so subject to change in Agave, and that this account does not exist in mainnet or testnet yet? 🙏
jumpsiegel
force-pushed
the
stake_redelegate
branch
from
01035d6 to
515b4d3
Compare
topointon-jump
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.