Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the complex_proxy submodule to work with Cofunction #151

Open
JHopeCollins opened this issue Dec 1, 2023 · 0 comments
Open

Update the complex_proxy submodule to work with Cofunction #151

JHopeCollins opened this issue Dec 1, 2023 · 0 comments
Labels
Core functionality Adding to the main paradiag functionality enhancement New feature or request

Comments

@JHopeCollins
Copy link
Member

We now use Cofunction for the right hand side of the block problem. Pedantically, the all-at-once functions that we copy the all-at-once residual into in the PC should also be Cofunction. However, cpx.{set,get}_{real,imag} doesn't work with Cofunction with the complex_proxy.vector implementation (seems fine with the complex_proxy.mixed implementation).

It would be good to fix this and change pc.xfr and pc.xfi to Cofunctions.
@JHopeCollins JHopeCollins added enhancement New feature or request Core functionality Adding to the main paradiag functionality labels Dec 1, 2023
@JHopeCollins JHopeCollins mentioned this issue Dec 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Core functionality Adding to the main paradiag functionality enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JHopeCollins