Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore non-linear waveform relaxation method #34

Open
JHopeCollins opened this issue May 4, 2022 · 0 comments
Open

Restore non-linear waveform relaxation method #34

JHopeCollins opened this issue May 4, 2022 · 0 comments
Labels
Core functionality Adding to the main paradiag functionality enhancement New feature or request

Comments

@JHopeCollins
Copy link
Member

Currently the non-linear waveform relaxation method is not fully implemented correctly because the contribution to the tail term from the last iteration is not calculated.
The waveform relaxation was previously implemented and got removed in the move to the parallel implementation. This should be restored so we can compare to the other paradiag variants.

This will need a case in the paradiag.solve method to manage the relaxation iterations instead of solving in one shot.
@JHopeCollins JHopeCollins self-assigned this May 4, 2022
@colinjcotter colinjcotter added the enhancement New feature or request label May 11, 2022
@JHopeCollins JHopeCollins added the Core functionality Adding to the main paradiag functionality label May 18, 2022
@JHopeCollins JHopeCollins removed their assignment May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Core functionality Adding to the main paradiag functionality enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@colinjcotter @JHopeCollins