Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DiagFFTPC.apply into smaller methods #44

Open
JHopeCollins opened this issue May 17, 2022 · 0 comments
Open

Refactor DiagFFTPC.apply into smaller methods #44

JHopeCollins opened this issue May 17, 2022 · 0 comments
Assignees
@JHopeCollins
Labels
Core functionality Adding to the main paradiag functionality refactor Tidy up existing functionality

Comments

@JHopeCollins
Copy link
Member

The DiagFFTPC.apply() method is currently quite long. This function applies the paradiag 3-step, so could be split up into three methods:

  • diagonalise / to_eigenbasis
  • block_solves
  • undiagonalise / from_eigenbasis
    This would be clearer, and allow for finer-grained testing.
@JHopeCollins JHopeCollins added the refactor Tidy up existing functionality label May 17, 2022
@JHopeCollins JHopeCollins self-assigned this May 17, 2022
@JHopeCollins JHopeCollins added Core functionality Adding to the main paradiag functionality and removed Core functionality Adding to the main paradiag functionality labels May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JHopeCollins JHopeCollins

Labels
Core functionality Adding to the main paradiag functionality refactor Tidy up existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JHopeCollins