Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Cofunction self-assignment via interpolation #3939

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fix for Cofunction self-assignment via interpolation #3939

wants to merge 9 commits into from

Conversation

jrmaddison
Copy link
Contributor

Fixes #3935

dham
dham requested changes Dec 18, 2024
View reviewed changes
firedrake/interpolation.py Outdated Show resolved Hide resolved
tests/firedrake/regression/test_interp_dual.py Outdated Show resolved Hide resolved
@connorjward connorjward mentioned this pull request Jan 8, 2025
Closed
@jrmaddison jrmaddison force-pushed the jrmaddison/self_interpolation branch from 787083b to f244d31 Compare January 9, 2025 09:25
@connorjward
Copy link
Contributor

@jrmaddison just like #3965 please can you update this branch. It should then pass tests.

@jrmaddison jrmaddison force-pushed the jrmaddison/self_interpolation branch from f244d31 to 6735414 Compare January 22, 2025 17:09
@jrmaddison
Copy link
Contributor Author

@jrmaddison just like #3965 please can you update this branch. It should then pass tests.

Done

@jrmaddison jrmaddison mentioned this pull request Jan 23, 2025
Open
@jrmaddison jrmaddison force-pushed the jrmaddison/self_interpolation branch from 6735414 to 9c783cb Compare January 23, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbrubeck pbrubeck pbrubeck left review comments

@dham dham dham requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Self-assignment via Cofunction.interpolate
4 participants
@jrmaddison @connorjward @dham @pbrubeck