Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename state files to GameStates.x.js or States.xyz.js #1

Open
sole opened this issue Jun 17, 2014 · 0 comments
Open

Rename state files to GameStates.x.js or States.xyz.js #1

sole opened this issue Jun 17, 2014 · 0 comments

Comments

@sole
Copy link

sole commented Jun 17, 2014

Currently the game states are defined in js/game/game.js and js/game/preloader.js. Plus the GameStates variable is defined inside preloader.js.

To improve readability and make this hierarchy more visible by looking at the files, I'd suggest to...

  • move the definition of the GameStates variable out from js/game/preloader.js and onto a new file called /js/game/GameStates.js
  • rename js/game/preloader.js to js/game/GameStates.Preloader.js
  • rename js/game/game.js to js/game/GameStates.Game.js

I reckon that so many game in the paths can be tedious. I'd go even further and suggest just using States where it says GameStates. What do you think?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sole