Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$importerModel->getLogTrace() return empty string #131

Open
ildelux opened this issue Nov 2, 2022 · 2 comments
Open

$importerModel->getLogTrace() return empty string #131

ildelux opened this issue Nov 2, 2022 · 2 comments

Comments

@ildelux
Copy link

ildelux commented Nov 2, 2022

Hi, I've updated to the new version 2.0.1
Unfortunately the public function $importerModel->getLogTrace() return empty string.
It was very convenient to have the import log.
Why was it eliminated?
Would it be possible to get it back?
Or is there an other way to do get the same thing?
Thank you.

@sprankhub
Copy link
Member

@avstudnitz, I think I've noticed this myself in the past, and I think it happened during your bigger refactoring for v2. Do you have any idea / would you have the chance to look into this? 🙏

@avstudnitz
Copy link
Member

I'm using this process which works well:

try {
    $this->importer->processImport($importData);
} catch (\Exception $e) {
    $this->handleFatalError($e);
    throw $e;
} finally {
    $this->handleRowErrors($this->importer->getErrorAggregator()->getAllErrors());
}

The errors contain row number and error message so I can mark the entries for re-import or notify someone.

I don't have time to look into why the original function is not available any more at the moment, but I'll try to do that during the next hackathon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants