Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project references with non-ASCII characters in project name fail #47

Open
Arinluna opened this issue Nov 7, 2023 · 2 comments
Open
Labels
moreinfo More information requested to diagnose the issue

Comments

@Arinluna
Copy link

Arinluna commented Nov 7, 2023

HeatWave Version

1.0.2

Visual Studio Version

17.7.6

Repro Steps

  1. Add any project to the solution with a name that contains a non-ASCII character. For example: 'ű'
  2. Add said project as a project reference to the installer project
  3. Try to build
    Addendum: The original .wixproj was updated from WIX v3 using HeatWave. I know that WIX v3 is not WIX v4, but WIX v3 was able to build the .msi using the original non-ACSII project names.

Actual Result

error WIX0150: Undefined preprocessor variable '$(var.AdatGyűjtőSvc.TargetDir)'

Expected Result

A succesfuly built .msi package, since the source project builds correctly.
Or, the very least, an error message that is relevant to the actual issue. I don't think that: "Undefined preprocessor variable $(var.MyNonAsciiProjectName.TargetDir)" is the relevant message, since some other component had to fail to create that variable in the first place.

@Arinluna Arinluna added the triage To be reviewed by FireGiant label Nov 7, 2023
@firegiantco
Copy link

We are not able to reproduce this issue. Can you provide a sample solution that demonstrates the error please?

@firegiantco firegiantco added moreinfo More information requested to diagnose the issue and removed triage To be reviewed by FireGiant labels Jan 11, 2024
@Arinluna
Copy link
Author

Sample.zip
The sample is the recreation of the structure of the solution with my original issue. Package.wxs should be the same as in the original solution (adjusted to the older project names).
The sample should also contain a screenshot with the messages.
HeatWave version is still 1.0.2
Visual Studio is version 17.7.7 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
moreinfo More information requested to diagnose the issue
Projects
None yet
Development

No branches or pull requests

2 participants