Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into making FuelModels objects use less memory in cases where multiple Behave objects are used simultaneously #2

Open
wchatham opened this issue Feb 26, 2016 · 3 comments
Assignees

Comments

@wchatham
Copy link
Contributor

Look into passing a pointer to a FuelModels object to Behave when an instance of Behave is constructed to save memory usage in applications using multiple instances of Behave objects.

@wchatham wchatham self-assigned this Feb 26, 2016
@wchatham
Copy link
Contributor Author

wchatham commented Apr 6, 2016

Made FuelModels object static to save memory usage when multiple behave instances are used simultaneously. Not sure if this is the optimal solution, as this may possibly introduce race conditions. Leaving this issue open for now.

@wchatham wchatham changed the title Look into moving FuelModels outside of Behave Look into making FuelModels objects use less memory in cases where multiple Behave objects are used simultaneously Apr 6, 2016
@wchatham
Copy link
Contributor Author

wchatham commented Apr 7, 2016

I've added some OpenMP critical sections to methods that alter data in FuelModels. Hopefully this will avoid race conditions associated with FuelModels objects assuming OpenMP is used to parallelize client applications.

@wchatham
Copy link
Contributor Author

Moved FuelModels outside of Behave, now passing a reference to it at behaves construction. Removed critical sections of FuelModels for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant