Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow simulations with 0 speed and 0 direction for simulating diurnal wind component only #442

Open
nwagenbrenner opened this issue Mar 15, 2022 · 1 comment
Open

Allow simulations with 0 speed and 0 direction for simulating diurnal wind component only #442

nwagenbrenner opened this issue Mar 15, 2022 · 1 comment
Labels
enhancement severity:med
Milestone
Unplanned

Comments

@nwagenbrenner
Copy link
Member

This is sometimes done by IMETs for estimating slope flow timing and strength, but they have to alter the wind direction to be >0, otherwise WindNinja throws an error. We could consider adding an option to simulate just the diurnal wind component.
@nwagenbrenner nwagenbrenner added this to the Unplanned milestone Mar 15, 2022
@latwood
Copy link
Collaborator

latwood commented Sep 30, 2024

This one seems to be fixed by the same fix for issue #526. Testing it out in the gui, seems to work, did some tests in the cli and it worked as well. The warning flags could potentially be fixed up in the gui though.

latwood added a commit that referenced this issue Oct 1, 2024
@latwood
setup the new massMeshVtk outputs to be the standard vtk output for m…
909d525 
…omentum solver runs. In other words, re-enabled vtk output for the momentum solver (issue #442), including in the gui, with descriptions warning it isn't the full momentum solver case vtk files but is just vtk files of a corresponding mass solver mesh.

This involved removing the alternate CPLConfigOptions for massMeshVtk output as well as updating the massMeshVtk output filenaming to the standard vtk output naming style. Interestingly, using input.volVTKOutFlag for the massMeshVtk outputs enabled the vtk output for ninjafoam diurnal runs, which wasn't happening before, ninjafoam diurnal runs are still built using the output surface grids but instead of outputting the ninjafoam massMesh modified for the diurnal winds, it just outputs the resulting diurnal mass solver run vtk files.
latwood added a commit that referenced this issue Oct 1, 2024
@latwood
updated warning flags for 0 wind speed 0 wind direction cases in gui,…
42de104 
… for issue #442 though related to issue #526. Note that the cli was already running 0 wind speed in combination with 0 wind direction, and a few of the last commits enabled WindNinja to handle the 0 wind speed and 0 wind direction cases more robustly
latwood added a commit that referenced this issue Oct 9, 2024
@latwood
stepped back update to gui warning flags for 0 wind speed 0 wind dire…
abeb17c 
…ction cases, but also adding gui warning flags for non diurnal 0 wind speed non zero wind direction cases. Intent is to only allow 0 wind speed runs for diurnal runs in the gui.

for issue #442, related to issues #526
latwood added a commit that referenced this issue Oct 9, 2024
@latwood
one last update to the gui 0 wind speed warning flags. for issue #442,…
1959ae7 
… related to issue #526

Noticed that the last fix wasn't quite handling more than one run in the gui correctly, and in the process found that the way the number of runs was counted when zeros in between rows needed updated, as well as that the wind speed table was only updating the warnings if the first row was updated. Was a bit worried to connect each of the 64 nRuns, but it didn't seem to slow anything down so I went ahead with the fix to allow proper nRun counting and updating at any changes to any row of wind speed and wind direction values.

Didn't see anything related to checking the values in the table if anything other than wind speed and wind direction were changed though. For now this should be good enough.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement severity:med
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
2 participants
@nwagenbrenner @latwood