Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vent overlap warning messages #13665

Closed
gforney opened this issue Oct 31, 2024 · 4 comments
Closed

vent overlap warning messages #13665

gforney opened this issue Oct 31, 2024 · 4 comments
Assignees

Comments

@gforney
Copy link
Contributor

gforney commented Oct 31, 2024

starting with this commit

Date: Wed Oct 30 14:50:49 2024 -0400
FDS Source: firemodels/smv#2085. Add flags to indicate OBST face hidden

I'm getting vent overlap warning for this case

smv/Verification/Visualization/vcirctest2.fds

I was not getting warning messages before this commit. The overlaps are real. The case has an open vent and also a circular vent on each of the 6 exterior walls. A side question, is there a better way to setup the case.

@mcgratta
Copy link
Contributor

Ah, this is feature, not a bug. When I made the change to print extra information to the smv file about OBST faces, I had to move the location of the call statement for the subroutine that writes the smv file. Since this case is a "setup only", in the past, we would have never reached that part of the code that would print these warnings. Now we do. Good news is that these warnings are good to see if you were doing a setup check.

@gforney
Copy link
Contributor Author

gforney commented Oct 31, 2024

do you have any suggestions on how I could set up this case to avoid warnings ie to put a circular vent on an external boundary?

@mcgratta
Copy link
Contributor

Did you change the order of the VENT lines?

@gforney
Copy link
Contributor Author

gforney commented Oct 31, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants