Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knudsen number off by a factor of 2 #13926

Open
johodges opened this issue Dec 20, 2024 · 1 comment
Open

Knudsen number off by a factor of 2 #13926

johodges opened this issue Dec 20, 2024 · 1 comment
Assignees

Comments

@johodges
Copy link
Collaborator

Describe the bug
I was looking at the tech guide to better understand how we are predicting deposition. The guide defines the Knudsen number as:

Kn = lambda/radius

But in the code Kn is calculated by dividing by the diameter:

Wall line 1584: KN = KN_FAC/SM%THERMOPHORETIC_DIAMETER
Wall line 1589: KN = KN_FAC/SM%MEAN_DIAMETER
Wall line 1595: KN = KN_FAC/SM%MEAN_DIAMETER

Jason and I discussed this a few weeks ago and he indicate the following in an email. We have not had a chance to fix it yet, so adding this issue so it does not get lost.

Email from Jason

Good catch.

I had meant to account for that with KN_FAC.

Kn = lambda/r = 2 lambda / d

lambda = mu sqrt (1/2 pi/(rho P))

so KN_FAC should be 2 * lambda = mu sqrt (2 pi / (rho P)) but in the source it is now the ½.

Looking at the revision history KN_FAC was correct until about 6.7.6. Probably not thinking and while adding condensation just saw I had 2 rather than 1/2 in the square root for lambda and forgot the diameter correction (or Amy had reviewed the source and asked why and I forgot the diameter thing). So can return this back and fix the verification cases and should add a comment in the source to note that KN_FAC includes the factor of two for diameter.

@johodges johodges changed the title Knudsen number of by a factor of 2 Knudsen number off by a factor of 2 Dec 20, 2024
drjfloyd added a commit that referenced this issue Dec 25, 2024
FDS Source: Fix Kn number calculation and associated verification Issue #13926
@drjfloyd
Copy link
Contributor

Fixed the source and think I got all the verification results fixed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants