look at linking slices in smokeview menus to &SLCF entries in input file

[gforney]

now smokeview collects slices together based upon their location. associating slices with &SCLF input file entries would allow the user to view slices as they are defined in the input file

[obscureed]

I haven't completely understood what you're working towards here, but I do have an enhancement request that might be partially relevant: It would be really nice if slices could be named, with the names visible in the smokeview load menu. Currently, I have to remember which slice is which.

[rmcdermo]

Related to this, it would also be nice if a given slice index was consistent from mesh to mesh. Say, I have a horizontal slice plane (PBZ=...) and I also have a vertical slice plane (PBY). If I have a mesh block arrangement that is 6 x 6 in x and y, then a given slice (say 'HRRPUV') in the z plane my have an index of 1 in most of the meshes, except the meshes where the vertical slice also lives (assuming I listed the vertical slice first in the input file). As I write post-processing scripts to make use of the slice data (using slread.m) this becomes challenging, the scripts get ugly. If the slices had an ID, this could be used instead of the index, though an ID string can usually have spaces and we'd want to avoid this in file names.

[gforney]

creating slice menus in smokeview is pretty messy. something like this could simplify things. think fds is now outputting some type of slice index nowto the smv file but for some reason which I can't remember there was a problem. I'll take another look.

[rmcdermo]

Hmmm... ID is already a parameter on SLCF. I've never used it though.

[gforney]

I'll check to see if smokeview uses it. one stumbling block is that the ids or sequence nubmers fds outputs to the smv file are not unique. If you have this line in your input file &SLCF PBX=1.0, QUANTITY='TEMPERATURE', VECTOR=.TRUE. / fds will output the same sequence number for a temperature slice and 3 additional velocity slices that it generates. Also the ID on the SLCF line may not be the same sequence number I am talking about. there is a way to do this - I have just have to think some more

…

On Fri, Dec 4, 2020 at 1:10 PM Randy McDermott ***@***.***> wrote: Hmmm... ID is already a parameter on SLCF. I've never used it though. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#1026 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC6UCRXRBUI66XEF2RKTKJTSTEQ2VANCNFSM4RR6IHZA> .

-- Glenn Forney

[JakeOShannessy]

I use the ID parameter of slices quite extensively. Not only does it show up in the load menu (by name), but use it when running scripts to great effect.

[gforney]

Thanks for the feedback!

…

On Fri, Dec 4, 2020, 4:36 PM JakeOShannessy ***@***.***> wrote: I use the ID parameter of slices quite extensively. Not only does it show up in the load menu (by name), but use it when running scripts to great effect. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#1026 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC6UCRSNQSZUPFV2TQQSEXDSTFI6HANCNFSM4RR6IHZA> .

[gforney]

I had forgotten that I make use of the ID keyword from the &SLCF namelist. If you add ID='test111' to a &SLCF line, the attached image is what you'll see in a slice menu in smokeview so you can annotate your slice file menus.

[obscureed]

This works for me and is good news -- thanks! (OK, it doesn't apply to vector slices -- but you can look in the Slice menu, find the name, memorise the coordinates and then use them in the vector slice menu.)

If anyone else is reading this and wondering whether you can use the same name for different quantities: yes, you can. (So, for example, you can apply ID='stairdoor' to a pressure slice and to a temperature slice, presumably at the same location.) On the other hand, if you apply two different names to the same quantity at the same location, you only see the first name in the GUI.

JakeOShannessy: Thanks for the tips! Please could you tell me the syntax for a script command that uses slice ID, and/or point me to the documentation? (Or do you mean that you record a script of finding the slice by hand, and use this as the start of script-writing?)

[gforney]

take a look at smokeview here at link below. The slice id's should now show up in vector slice menus.

https://drive.google.com/drive/folders/0B_wB1pJL2bFQc1F4cjJWY2duWTA?usp=sharing

also, I implemented a new smokeview script command, LOADSLCF that is friendlier than LOADSLICE or LOADFILE. LOADSLCF mimics the &SLCF name list use in an FDS input file

If you had

&SLCF PBY=1.0, QUANTITY='TEMPERATURE' VECTOR=T ID='y slice' /
&SLCF PBX=1.0, QUANITTY='TEMPERATURE' CELL_CENTERED ID='x slice' /

in your input file you could use either

LOADSLCF
ID='y slice'

LOADSLICE
QUANTITY='TEMPERATURE' PBY=1.0

to load the Y slice. To load the y slice as a vector slice add VECTOR=T

LOADSLICE
QUANTITY='TEMPERATURE' PBY=1.0 VECTOR=T

or

LOADSLCF
ID='y slice' VECTOR=T

To load the X cell centered slice use

LOADSLCF
ID='x slice'

or

LOADSLICE
QUANTITY='TEMPERATURE' PBY=1,0 CELL_CENTERED=T

I have tested this command and it seems to work but it is new. If you use it and see problems let me know

[gforney]

typo, should have been
&SLCF PBX=1.0, QUANITTY='TEMPERATURE' CELL_CENTERED=T ID='x slice' /

[rmcdermo]

I've played with the ID stuff. It is definitely helpful. But, for me, it does not get all the way to what I need because the filenames in the working directory are all still based on indices. True, now at least it is easy to manually look in the smv file and match up my ID to the .sf file I want. And it is true that I could somehow parse this automatically, but that seems at bit kludgy.

@JakeOShannessy, I am not sure what type of scripts you are talking about, unless they are the smv script language. When I'm trying to develop Python or Matlab scripts, it would be much cleaner if ID were somehow used in the filename instead of an index. Am I missing something?

[gforney]

I suggest that fds outputs one file for each ID . This file would contain a list of files with that ID. One problem though is that if you have VECTOR=T on a slice line the same ID is assigned to the 'QUANTITY' files and also to those files associated with U-VEL, V-VEL and W-VEL . You can't really use ID's in the file name unless you want to disallow embedded blanks in IDs . (blanks in files names would be a big problem)

…

On Tue, Dec 8, 2020 at 1:49 PM Randy McDermott ***@***.***> wrote: I've played with the ID stuff. It is definitely helpful. But, for me, it does not get all the way to what I need because the filenames in the working directory are all still based on indices. True, now at least it is easy to manually look in the smv file and match up my ID to the .sf file I want. And it is true that I could somehow parse this automatically, but that seems at bit kludgy. @JakeOShannessy <https://github.com/JakeOShannessy>, I am not sure what type of scripts you are talking about, unless they are the smv script language. When I'm trying to develop Python or Matlab scripts, it would be much cleaner if ID were somehow used in the filename instead of an index. Am I missing something? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#1026 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC6UCRRENSUDOJEST56TZ2LSTZYKZANCNFSM4RR6IHZA> .

-- Glenn Forney

[rmcdermo]

No need to add more files. If I need something like that, I'd just parse the smv file, it's al there.

I'm not suggesting you make this a big priority, I'm just commenting on things from my point of view. Blanks are not hard to deal with; for example, Python will make a rule to insert a hyphen for the blank.

[gforney]

for whatever it is worth, smokeview does not care about the file name except for blanks which as you said is easy to address. so if fds were to output the ID in part of the name instead of an integer it wouldn't break smokeview

…

On Tue, Dec 8, 2020 at 2:11 PM Randy McDermott ***@***.***> wrote: No need to add more files. If I need something like that, I'd just parse the smv file, it's al there. I'm not suggesting you make this a big priority, I'm just commenting on things from my point of view. Blanks are not hard to deal with; for example, Python will make a rule to insert a hyphen for the blank. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#1026 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC6UCRW3YNAN4TC6HXH7UG3STZ25NANCNFSM4RR6IHZA> .

-- Glenn Forney

[JakeOShannessy]

@rmcdermo, @obscureed: The scripting I'm referring to is using the lua hooks within smokeview (they're under a preprocessor directive) so neither SSF nor completely external.

Since the scripts are internal to smokeview they have access to the labels which are parsed by the smokeview parser, so at the very least I can be consistent with smokeview. The format of the .smv files relies on ampersand to delimit the end of an id, so whitespace hasn't been an issue although ampersands would be.

If you're curious, the label is simply stored in the struct for slicedata...

typedef struct _slicedata {
  ...
  char *slicelabel;
  ...
}

... and I match on that when loading slices (or doing whatever else).

function load.namedslice(name)
    local result, indices = load.slice(function(slice)
        return (slice.label == name)
    end)
    if (result ~= 0) then
        error("Slice named " .. name .. " could not be found.")
    end
    return result, indices
end

[rmcdermo]

@JakeOShannessy Thanks for the explanation. Sounds like I just need to build a .smv parser for Matlab or Python. Might be a good summer student project.