Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pausing tours #2104

Closed
gforney opened this issue Dec 11, 2024 · 10 comments
Closed

pausing tours #2104

gforney opened this issue Dec 11, 2024 · 10 comments
Assignees

Comments

@gforney
Copy link
Contributor

gforney commented Dec 11, 2024

Would still be nice to have complete control over the times of keyframes – both the time of arrival and the dwell time. The pause feature is helpful but it is a bit fiddly as changing the pause for one item means all the other times get recomputed to keep the constant velocity over the remaining time.

@gforney
Copy link
Contributor Author

gforney commented Dec 28, 2024

@drjfloyd update your smv repo and build smokeview or try smokeview posted here or use a nightly bundle after the next firebot pass
https://github.com/gforney/test_bundles/releases/tag/SMOKEVIEW_TEST

you can modify interior tour keyframe times (all but first and last keyframe times) by using attached dialog box. click the 'Set time' checkbox to allow editing time for selected keyfraome. to change the time for the first or last keyframe you need to click on the settings tab and edit 'start time' and/or 'stop time' widgets. (these two widgets existed before I made these changes) these widgets apply for all tours. I need to think a bit about how best to consolidate these two sets of widgets. that is would you want two tours to start at different times.

tour_dialog

@drjfloyd
Copy link
Contributor

I pulled down the lateset smv source. Did a git reset --hard and git clean -dxf to make sure I had a good clean repo. Built the Windows version. My dialog box still looks like the old and doesn't have the checkbox for constant velocity or set time.

image

@gforney
Copy link
Contributor Author

gforney commented Dec 28, 2024 via email

@gforney
Copy link
Contributor Author

gforney commented Dec 29, 2024

update your repo again, I pushed up some changes unrelated to this touring stuff ( I know what the latest revision should be after this 'push') . after rebuilding smokeview type

smokeview -v

where smokeview is the name of the exe built. the revision line should look like
Revision : SMV-6.9.5-177-ge0f6834-master

also type git describe --dirty --long in your smv repo. you should see the same hash. if you are seeing the same hash and you are still not seeing the new widgets upload a case that you are looking at. maybe there is some type of case dependenent bug

@gforney
Copy link
Contributor Author

gforney commented Dec 30, 2024

I'm revamping the tour dialog box (making time boiunds more consistent). hold off checking until I push changes again

@drjfloyd
Copy link
Contributor

I compiled with the latest PR and the dialog box works well. I can set times and pause at each point. Thanks Glenn!

@gforney
Copy link
Contributor Author

gforney commented Dec 31, 2024 via email

@drjfloyd
Copy link
Contributor

I made a tour with changes to time and pauses for some nodes, saved the ini, closed smokeview, restarted smokeview, loaded the smv file, and the tour was there with the changes.

@gforney
Copy link
Contributor Author

gforney commented Dec 31, 2024 via email

@gforney
Copy link
Contributor Author

gforney commented Jan 2, 2025

I'll close the issue. we can reopen it if you find any problems or have any suggestions

@gforney gforney closed this as completed Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants