-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pausing tours #2104
Comments
@drjfloyd update your smv repo and build smokeview or try smokeview posted here or use a nightly bundle after the next firebot pass you can modify interior tour keyframe times (all but first and last keyframe times) by using attached dialog box. click the 'Set time' checkbox to allow editing time for selected keyfraome. to change the time for the first or last keyframe you need to click on the settings tab and edit 'start time' and/or 'stop time' widgets. (these two widgets existed before I made these changes) these widgets apply for all tours. I need to think a bit about how best to consolidate these two sets of widgets. that is would you want two tours to start at different times. |
Ill see whats going on
…On Sat, Dec 28, 2024, 12:43 PM Jason Floyd ***@***.***> wrote:
I pulled down the lateset smv source. Did a git reset --hard and git clean
-dxf to make sure I had a good clean repo. Built the Windows version. My
dialog box still looks like the old and doesn't have the checkbox for
constant velocity or set time.
image.png (view on web)
<https://github.com/user-attachments/assets/589d910e-0e15-474f-bf1d-1cd9abd97e80>
—
Reply to this email directly, view it on GitHub
<#2104 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC6UCRRD5KPZQMA2ZFA73Q32H3PNNAVCNFSM6AAAAABTN3ZXSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRUGM4DQNZZGU>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
update your repo again, I pushed up some changes unrelated to this touring stuff ( I know what the latest revision should be after this 'push') . after rebuilding smokeview type smokeview -v where smokeview is the name of the exe built. the revision line should look like also type git describe --dirty --long in your smv repo. you should see the same hash. if you are seeing the same hash and you are still not seeing the new widgets upload a case that you are looking at. maybe there is some type of case dependenent bug |
I'm revamping the tour dialog box (making time boiunds more consistent). hold off checking until I push changes again |
I compiled with the latest PR and the dialog box works well. I can set times and pause at each point. Thanks Glenn! |
good! one thing I was going to check some more is to make sure I could
save a tour to an .ini file and have it come back as I defined it (with
custom times) the next time I opened smokeview. let me know if you see
problems with this
…On Tue, Dec 31, 2024 at 10:24 AM Jason Floyd ***@***.***> wrote:
I compiled with the latest PR and the dialog box works well. I can set
times and pause at each point. Thanks Glenn!
—
Reply to this email directly, view it on GitHub
<#2104 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC6UCRQ2IK4SYBKOZ6AJDWT2IKZLHAVCNFSM6AAAAABTN3ZXSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRWGUZTGNRSGQ>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
--
Glenn Forney
|
I made a tour with changes to time and pauses for some nodes, saved the ini, closed smokeview, restarted smokeview, loaded the smv file, and the tour was there with the changes. |
good, thanks
…On Tue, Dec 31, 2024 at 11:00 AM Jason Floyd ***@***.***> wrote:
I made a tour with changes to time and pauses for some nodes, saved the
ini, closed smokeview, restarted smokeview, loaded the smv file, and the
tour was there with the changes.
—
Reply to this email directly, view it on GitHub
<#2104 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC6UCRWG56M6OVB6UY7IL3L2IK5RPAVCNFSM6AAAAABTN3ZXSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRWGU2TMOJSGA>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
--
Glenn Forney
|
I'll close the issue. we can reopen it if you find any problems or have any suggestions |
Would still be nice to have complete control over the times of keyframes – both the time of arrival and the dwell time. The pause feature is helpful but it is a bit fiddly as changing the pause for one item means all the other times get recomputed to keep the constant velocity over the remaining time.
The text was updated successfully, but these errors were encountered: