Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible dims mistmatch in Time GAN #2

Open
FrancescoSaverioZuppichini opened this issue Apr 20, 2020 · 0 comments
Open

Possible dims mistmatch in Time GAN #2

FrancescoSaverioZuppichini opened this issue Apr 20, 2020 · 0 comments

Comments

@FrancescoSaverioZuppichini

Dear all,

In the TimeGAN implementation you define the reconstruction loss as:

E_loss_T0 = tf.losses.mean_squared_error(X, X_tilde)

E_loss_T0 = tf.losses.mean_squared_error(X, X_tilde)

Where X must have dims [BATCH, SEQ_LEN, INPUT_SIZE] and so X_tilde but X_tilde is generated using a RNN + FC (even if the paper stated that only a FC was used) so the output is a two dims vector [BATCH, INPUT_SIZE] since it is defined as

    def recovery (H, T):      
      
        with tf.variable_scope("recovery", reuse = tf.AUTO_REUSE):       
              
            r_cell = tf.nn.rnn_cell.MultiRNNCell([rnn_cell(module_name) for _ in range(num_layers)])
                
            r_outputs, r_last_states = tf.nn.dynamic_rnn(r_cell, H, dtype=tf.float32, sequence_length = T)
            
            X_tilde = tf.contrib.layers.fully_connected(r_outputs, data_dim, activation_fn=tf.nn.sigmoid) 

        return X_tilde

Therefore the dimensions are wrong and the loss is not complete. Am I wrong?

Thank you,

Francesco Saverio Zuppichini

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant