Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datatables v2 breaks table layouts #4964

Closed
ddrury opened this issue Mar 19, 2024 · 6 comments
Closed

Datatables v2 breaks table layouts #4964

ddrury opened this issue Mar 19, 2024 · 6 comments
Labels
bug confirmed bug upstream error in a third-party library

Comments

@ddrury
Copy link
Contributor

ddrury commented Mar 19, 2024

At commit e124422,

Cell borders missing and cell alignment is wrong (visible on latest demo)

@ddrury
Copy link
Contributor Author

ddrury commented Mar 21, 2024

This is caused by commit d11b6d8 updating datatables.net-bs5 to version 2.0.2

1.13.11 works, 2.0.1 doesn't

See Upgrading to DataTables 2

@fisharebest
Copy link
Owner

Oops - that's not good.

@fisharebest fisharebest added the bug confirmed bug label Mar 21, 2024
@fisharebest
Copy link
Owner

I think it's related to DataTables/Dist-DataTables-Bootstrap5#11

@fisharebest fisharebest added the upstream error in a third-party library label Mar 22, 2024
@ddrury
Copy link
Contributor Author

ddrury commented Mar 26, 2024

There are at least another couple of things that need attention,

  1. resources/views/lists/datatables-attributes.phtml will need significant work (in particular the new layout attribute)
  2. something I've not fully figured out yet, take the Individual surname list (resources/views/lists/surnames-table.phtml), the first column is right justified and examining the html it gets the class dt-type-numeric. Changing it in the html does correct the alignment but changing the code has no effect so I guess it's added as a default by datatables - does this mean we have to define all columns for every table?

fisharebest added a commit that referenced this issue Apr 3, 2024
fisharebest added a commit that referenced this issue Apr 3, 2024
@fisharebest
Copy link
Owner

I have downgraded to datatables 1.x until the upstream issue is fixed.

Keep this issue open until we can work with 2.x.

@ddrury ddrury changed the title Individuals & Families (and maybe others) list malformed table Datatables v2 breaks table layouts Apr 3, 2024
@miqrogroove
Copy link
Contributor

I thought it was intentional. I like the wider name fields. Maybe just row borders should come back.

fisharebest added a commit that referenced this issue Oct 30, 2024
ddrury pushed a commit to ddrury/webtrees that referenced this issue Nov 27, 2024
ddrury pushed a commit to ddrury/webtrees that referenced this issue Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed bug upstream error in a third-party library
Projects
None yet
Development

No branches or pull requests

3 participants