Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Update reserved word handling #35

Open
2 of 4 tasks
fivetran-catfritz opened this issue Feb 16, 2023 · 0 comments
Open
2 of 4 tasks

[Feature] Update reserved word handling #35

fivetran-catfritz opened this issue Feb 16, 2023 · 0 comments
Labels
priority:p4 Affects few users; pick up when available type:enhancement New functionality or enhancement update_type:documentation Primary focus requires documentation updates

Comments

@fivetran-catfritz
Copy link
Contributor

fivetran-catfritz commented Feb 16, 2023

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

Revise logic to better accommodate different user setups and add documentation to readme to account to give instructions on what to do when our yml settings get overridden.

Things to update:

  1. Update src yml

from:

  - name: order
    identifier: >
      {% if target.type == 'snowflake' %}{{ var('salesforce_order_identifier', '"ORDER"') }}
      {% else %}{{ var('salesforce_order_identifier', 'order') }}{% endif %}

to

  - name: order

  # remove double quotes and add necessary whitespace control
    identifier: >
      {% if target.type == 'snowflake' %}{{ var('salesforce_order_identifier', 'ORDER') }} 
      {%- else %}{{ var('salesforce_order_identifier', 'order') }}{% endif %} 

  # turn on quoting for the identifier in this table
    quoting:
      identifier: true 
  1. Update our intergration_test dbt_project.yml vars

from:

salesforce_order_identifier: "sf_order_data"

to

order: "{{ ref('sf_order_data') }}" 
  1. Update Snowflake Users Section of README to add (something like):

If you have sources defined in your project's yml, instead you will need to add the below where your order table is defined in your yaml:

tables:
  - name: order 
    # Add the below
    identifier: ORDER # Or what your order table is named, being mindful of casing
    quoting:
      identifier: true

Describe alternatives you've considered

No response

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

No response

@fivetran-catfritz fivetran-catfritz added the enhancement New feature or request label Feb 16, 2023
@fivetran-catfritz fivetran-catfritz changed the title [Feature] Up [Feature] Update reserved word handling Feb 16, 2023
@fivetran-joemarkiewicz fivetran-joemarkiewicz added priority:p4 Affects few users; pick up when available type:enhancement New functionality or enhancement update_type:documentation Primary focus requires documentation updates and removed enhancement New feature or request labels Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p4 Affects few users; pick up when available type:enhancement New functionality or enhancement update_type:documentation Primary focus requires documentation updates
Projects
None yet
Development

No branches or pull requests

2 participants