Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a user when creating a rabbitmq delivery #184

Open
tttp opened this issue Nov 16, 2022 · 8 comments
Open

create a user when creating a rabbitmq delivery #184

tttp opened this issue Nov 16, 2022 · 8 comments
Labels
enhancement New feature or request

Comments

@tttp
Copy link
Member

tttp commented Nov 16, 2022

as discussed with @marcinkoziej, when creating a delivery queue for an organisation, create as well a user (org name) and a password (long and random) with read access to cus.xxx.deliver

also (tiny detail), could we change the command? instead of:

$proca org:set --custom-deliver org_name

go for something more discoverable, like

$proca service:deliver org_name

rationale: can never remember what is the command and proca help isn't helping ;)

@tttp tttp added the enhancement New feature or request label Nov 16, 2022
@marcinkoziej
Copy link
Contributor

Prehaps proca queue or similar

@marcinkoziej
Copy link
Contributor

generally the services are creadentials for external services, need to think if the rabbitmq should be put in the same basket... so that's perhaps just proca queue idea

@tttp
Copy link
Member Author

tttp commented Nov 16, 2022

the existing help:

  service          List services in org
  service:detail   Configure detail service-related options for org.
  service:email    Configure email-related options for org.
  service:event    Configure event service-related options for org.
  service:push     Configure detail service-related options for org.
  service:set      Set service settings (create if not exists).
  service:storage  Configure storage-related options for org.

I'm fine with queue, don't have strong opinion on the name, but ... I only understand email (as setting smtp or mailjet... ?), don't understand what detail, even, push, set or storage do

@marcinkoziej
Copy link
Contributor

Detail - lookup supporter details (TRUST API use case)
Event - configure service to push proca events (new action page, etc)
Push - configure service to push actions (that "push name came out of our discussions on pull vs push... but looking back not the best name)
Storage - fetch MTT attachments from (right now)

  • all these backends can point to different services (by service name: push can be webhook or sqs, storage - can be supabase [or S3]), detail is http fetch but we could add civicrm lookup etc.

@marcinkoziej
Copy link
Contributor

marcinkoziej commented Nov 17, 2022

And there is also "custom" handling so the queues. They are not services in the sense that Proca server does not know what service is the queue client - it just pushes to queues.

In case of services (like push or event or email) they also read from the queue, so it's Request Handler in Server->queue->Service Worker in Server

for custom queue it's

Request handler in Server->queue->??

@tttp
Copy link
Member Author

tttp commented Nov 19, 2022

@marcinkoziej , these descriptions are much clearer than the once on proca-cli help, can you update them or do you want me to PR?

$proca queue sounds fine to me

@marcinkoziej
Copy link
Contributor

pls PR the way you like it

@tttp
Copy link
Member Author

tttp commented Nov 24, 2022

I don't know how to create a rabbitmq user, but can change the proca-cli.

Is this going to be the same api or you want a change? at least either get the password as parameter or returns it, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants