Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send test actions #30

Open
1v4n4 opened this issue Oct 1, 2023 · 4 comments
Open

Don't send test actions #30

1v4n4 opened this issue Oct 1, 2023 · 4 comments

Comments

@1v4n4
Copy link
Member

1v4n4 commented Oct 1, 2023

We need to exclude test actions for Trust for sure, and probably for all the others.

@1v4n4
Copy link
Member Author

1v4n4 commented Oct 1, 2023

@tttp
If (!message.action.testing) in line 26?

@1v4n4 1v4n4 changed the title Dont sent test actions Don't send test actions Oct 1, 2023
@1v4n4
Copy link
Member Author

1v4n4 commented Oct 1, 2023

While we doing it, we might exclude duplicates as well (message.contact.dupeRank > 0)

@tttp
Copy link
Member

tttp commented Dec 4, 2023

not sure if it's wise to remove duplicates, as the latest action might have more information (eg the phone number) that the first ones)

@tttp
Copy link
Member

tttp commented Dec 4, 2023

test should be sent, but may be in a different tag/custom field? it's very dependent of the CRM how to flag it's a test vs regular one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants