Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Journal as trait #102

Open
marvin-j97 opened this issue Dec 6, 2024 · 2 comments
Open

Journal as trait #102

marvin-j97 opened this issue Dec 6, 2024 · 2 comments
Assignees
@Shubh-81
Labels
api enhancement New feature or request epic good first issue Good for newcomers help wanted Extra attention is needed refactor test

Comments

@marvin-j97
Copy link
Collaborator

This would allow skipping the journal (by implementing an empty impl that just returns Ok(())), (a)synchronous replication etc
@marvin-j97 marvin-j97 added api enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed test labels Dec 6, 2024
@Shubh-81
Copy link

Shubh-81 commented Dec 6, 2024

Can i get assigned to this issue?

@marvin-j97
Copy link
Collaborator Author

@Shubh-81 I have no intention working on this the next couple of months so yeah.

It will be a bit of effort to untangle the journal from the current implementation though, it's all pretty hard coded right now.

@marvin-j97 marvin-j97 mentioned this issue Dec 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shubh-81 Shubh-81

Labels
api enhancement New feature or request epic good first issue Good for newcomers help wanted Extra attention is needed refactor test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marvin-j97 @Shubh-81