Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gencodec generates vendored import path instead of regular path #8

Open
dimroc opened this issue Oct 24, 2018 · 1 comment
Open

gencodec generates vendored import path instead of regular path #8

dimroc opened this issue Oct 24, 2018 · 1 comment

Comments

@dimroc
Copy link

dimroc commented Oct 24, 2018

When running go generate ./..., gencodec writes the vendored import paths rather than the correct ones:

As seen here where we are using golang/dep to vendor our dependencies: smartcontractkit/chainlink#680 (comment)

Source

//go:generate gencodec -dir . -type Log -field-override logMarshaling -out gen_log_json.go

// Log represents a contract log event. These events are generated by the LOG opcode and
// stored/indexed by the node.
type Log struct {
...

Current Behavior

// Code generated by github.com/fjl/gencodec. DO NOT EDIT.

package store

import (
	"encoding/json"
	"errors"

	"github.com/smartcontractkit/chainlink/vendor/github.com/ethereum/go-ethereum/common"
	"github.com/smartcontractkit/chainlink/vendor/github.com/ethereum/go-ethereum/common/hexutil"
)

...

Expected behavior

// Code generated by github.com/fjl/gencodec. DO NOT EDIT.

package store

import (
	"encoding/json"
	"errors"

	"github.com/ethereum/go-ethereum/common"
	"github.com/ethereum/go-ethereum/common/hexutil"
)

...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant