Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new theme respecting @media(preferes-color-scheme: dark) #1186

Open
tats-u opened this issue Dec 15, 2024 · 0 comments
Open

A new theme respecting @media(preferes-color-scheme: dark) #1186

tats-u opened this issue Dec 15, 2024 · 0 comments

Comments

@tats-u
Copy link

tats-u commented Dec 15, 2024

Do you want to request a feature or report a bug?

feature

What is the current behavior?

All of themes don't respect @media(preferes-color-scheme: dark). Toasts are too dazzling unless you pass theme="dark" if the other parts of your apps respect that media query.
You have to use useMediaQuery in mui or usehooks-ts to know which is the best theme, "light" or "dark".

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Paste the link to your CodeSandbox (https://codesandbox.io/s/new) example below:

What is the expected behavior?

A new theme shall be implemented using @media(preferes-color-scheme: dark). An user agent that prefers the dark mode, the style of theme="dark" shall be applied. Otherwise, that of theme="light" shall be applied.
It should be the default behavior unless you pass the value of the theme attribute.
I prefer "auto" as the name of the proposed theme.

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?

All

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant