Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future API improvements #198

Open
heuer opened this issue May 14, 2024 · 2 comments
Open

Future API improvements #198

heuer opened this issue May 14, 2024 · 2 comments
Labels

Comments

@heuer
Copy link
Contributor

heuer commented May 14, 2024

This issue is intended to collect and discuss API improvement suggestions.

  • pointer: Replace dx and dy properties with delta_x and delta_y. The PointerMotionEvent has the properties "delta_x" and "delta_y". The other events call the same thing "dx" and "dy"
  • xwayland: Surface.or_surface_wants_focus: The name makes no sense at all. The underlying function is called xwayland_or_surface_wants_focus which makes sense, but in the context of the surface, the "or" makes no sense. Suggestion: Surface.wants_focus See comment below.
@heuer heuer changed the title API improvements Future API improvements May 14, 2024
@Consolatis
Copy link

The "or" stands for "override redirect" (not for ||) and basically means an unmanaged surface. Those are used in X11 for popups / tooltips and the like. See https://gitlab.freedesktop.org/wlroots/wlroots/-/blob/0.17/include/wlr/xwayland/xwayland.h?ref_type=heads#L262 for more details.

@heuer
Copy link
Contributor Author

heuer commented May 28, 2024

The "or" stands for "override redirect" (not for ||) and basically means an unmanaged surface. Those are used in X11 for popups / tooltips and the like. See https://gitlab.freedesktop.org/wlroots/wlroots/-/blob/0.17/include/wlr/xwayland/xwayland.h?ref_type=heads#L262 for more details.

Thank you. You're right. I read the wlr function name (by mistake) like "either xwayland or a surface". I'm unsure, even knowing my mistake, if I like the method name, though. ;)

Anyway, thanks for clearing up!

@flacjacket flacjacket added the api label Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants