Cloning a product without attributes doesn't work

[thomasheller]

Steps to reproduce:

1. Install flagbit/akeneo-product-cloner.
2. Create new product in Akeneo. Make sure the product has no attributes.
3. Select "Clone" from the menu.
4. Enter a product code.
5. Click "Save".

Actual result:

Blank dialog appears. The product is not cloned.

var/logs/prod.log shows:

request.CRITICAL: Uncaught PHP Exception Symfony\Component\Debug\Exception\FatalThrowableError: "Cannot use object of type stdClass as array" at /srv/pim/vendor/flagbit/product-cloner-bundle/src/Controller/AbstractController.php line 41 {"exception":"[object] (Symfony\\Component\\Debug\\Exception\\FatalThrowableError(code: 0): Cannot use object of type stdClass as array at /srv/pim/vendor/flagbit/product-cloner-bundle/src/Controller/AbstractController.php:41)"} []

Expected result:

Product should be cloned (or at least an error message should appear in the dialog).

[igormukhingmailcom]

The reason is:

• https://github.com/akeneo/pim-community-dev/blob/767ee9e7664218016094f907dd2e8f0cdfb97389/src/Akeneo/Pim/Enrichment/Component/Product/Normalizer/ExternalApi/ProductNormalizer.php#L67
• https://github.com/akeneo/pim-community-dev/blame/767ee9e7664218016094f907dd2e8f0cdfb97389/src/Akeneo/Pim/Enrichment/Component/Product/Normalizer/ExternalApi/ProductNormalizer.php#L67
• akeneo/pim-community-dev@325f366

The solution:

abstract class AbstractController extends Controller
...
    protected function normalizeProduct(EntityWithFamilyVariantInterface $product)
    {
        $normalizedProduct = $this->getNormalizer()->normalize($product, 'external_api');

        # @see https://github.com/flagbit/akeneo-product-cloner/issues/24
        if ($normalizedProduct['values'] instanceof \stdClass) {
            $normalizedProduct['values'] = [];
        }