Skip to content
This repository has been archived by the owner on Apr 29, 2021. It is now read-only.

Authorised example in README is wrong #11

Open
pryley opened this issue Apr 8, 2018 · 3 comments
Open

Authorised example in README is wrong #11

pryley opened this issue Apr 8, 2018 · 3 comments
Labels

Comments

@pryley
Copy link

pryley commented Apr 8, 2018

It should be like this (notice the "Token " string before the token).

$api = Flarum('http://example.com', ['token' => 'Token <insert-master-token>; userId=1']);
@clarkwinkelmann
Copy link

Hi, thanks for the report !

The README is indeed incorrect for all versions released, but it isn't worth fixing anymore given the future release (dev-master right now) automatically adds the token prefix:

Arr::set($headers, 'Authorization', "Token $token");

Not sure when we'll work on this package again though... Let's keep this issue open in the meantime in case somebody wonders the same thing.

@pryley
Copy link
Author

pryley commented Apr 8, 2018

Have you abandoned the package?

@clarkwinkelmann
Copy link

@pryley we will publish any security update necessary, but as you can guess from the commit history it's been a while since we've worked on new features for the package.

If beta8 requires us to make changes to the package we will probably release an update.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants