Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change theme to match flake.parts #7

Open
srid opened this issue Jan 23, 2024 · 4 comments
Open

Change theme to match flake.parts #7

srid opened this issue Jan 23, 2024 · 4 comments

Comments

@srid
Copy link
Member

srid commented Jan 23, 2024

@roberth Could you confirm that this is what you want community.flake.parts to look like?

image
@srid
Copy link
Member Author

srid commented Jan 23, 2024

And is this a builtin theme of mdbook? Where is it defined, btw?

@roberth
Copy link
Contributor

roberth commented Jan 23, 2024

Yes, it is a good example for a documentation theme, because it is a calm, flat style that doesn't distract from the content.
Also, a very similar style makes the two sites look more coherent.

It is mostly the default "light" theme, with a few overrides:
https://github.com/hercules-ci/flake.parts-website/blob/main/site/flake-parts.css

The rest of the theme is as defined upstream by mdBook here.

@srid
Copy link
Member Author

srid commented Feb 7, 2024

@roberth How do you find the Obsidian theme in comparison? https://publish.obsidian.md/tasks/Scripting/Custom+Sorting

Let's still do mdBook theme for consistency with flake.parts site, but am just curious.

@roberth
Copy link
Contributor

roberth commented Feb 7, 2024

The Obsidian theme has a couple of flaws, but the general looks is ok.

  • Saturated green text ("Released") on pastel green background: ugly and might be insufficient contrast (guessing; I'm no color vision expert)
  • Note background are label background are also dissonant.
  • Something's jarring about those colors in dark mode too. Maybe because the label background intensity matches the "Released" text color instead of its background.
  • Drop shadows look dated
  • Corner rounding is inconsistent
  • Their link color looks like the old color for already-visited links, but I suppose we'd use the flake-parts logo color anyway. At least that's what I did on flake.parts. (but only in the menu? - might want to apply that more broadly, but maybe not as bright? needs testing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants