Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Found a few duplicate test cases, you might want to take a look #3356

Open
10 tasks
incendial opened this issue Oct 27, 2024 · 3 comments
Open
10 tasks

Found a few duplicate test cases, you might want to take a look #3356

incendial opened this issue Oct 27, 2024 · 3 comments

Comments

@incendial
Copy link

incendial commented Oct 27, 2024

What could be improved

  1. Duplicate test cases in test/components/position_component_test.dart: this and that
  2. Duplicate test cases in test/components/priority_test.dart: this and that
  3. Duplicate test cases in test/components/scroll_text_box_component_test.dart: this and that one in another file (test/components/text_box_component_test.dart)
  4. Duplicate test cases in test/effects/color_effect_test.dart: this and that
  5. Duplicate test cases in test/experimental/has_game_reference_test.dart: this and that one in another file (test/components/mixins/has_game_ref_test.dart)
  6. Duplicate test cases in test/extensions/vector2_test.dart: this and that
  7. Duplicate test cases in test/game/game_widget/game_widget_lifecycle_test.dart: this and that one in another file (test/game/game_widget/game_widget_controlled_lifecycle_test.dart)
  8. Duplicate test cases in test/game/game_widget/game_widget_test.dart: this and that, also this and that
  9. Duplicate test cases in test/particles/circle_particle_test.dart: this and that one and also that one

Why should this be improved

It's unclear if these test cases are accidental duplicates and can be simply removed (or kept as is) or they need to be update to test different things.

Risks

Probably none.

More information

No response

Other

  • Are you interested in working on a PR for this?
@incendial
Copy link
Author

cc @spydon

@spydon
Copy link
Member

spydon commented Oct 27, 2024

Thanks for the report, I'll have a closer look later today!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@spydon @incendial and others