New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMPS Terminology needs updating #4

Open

flamewing opened this issue Sep 7, 2018 · 3 comments

Labels

Owner

flamewing commented Sep 7, 2018

Music and SFX files need to be updated to use the new terminology. In a nutshell:

smpsAlterNote → smpsDetune
smpsAlterPitch → smpsChangeTransposition
smpsSetvoice → smpsFMvoice
smpsWeirdD1LRR → smpsMaxRelRate
smpsFMFlutter → smpsFMVolEnv

Reference commit: b483d9c#diff-39d6459915b1c59c6d3a4b3b40cb4ad2

The text was updated successfully, but these errors were encountered:

flamewing added the enhancement label

Owner Author

flamewing commented Sep 7, 2018

This depends on #2.

Owner Author

flamewing commented Sep 21, 2018

Terminology reference.

flamewing mentioned this issue

[SMPS2ASM] SMPS Terminology needs updating flamewing/mdtools#5

Open

Owner Author

flamewing commented Sep 21, 2018

Related to this issue: flamewing/mdtools#5

Additional changes to dumped files:

smpsNoAttack → smpsHoldNote
smpsAlternameSMPS → smpsRawFreqMode
smpsSetvoice → smpsFMInstrument
smpsPSGvoice → smpsPSGInstrument
smpsHaltMusic → smpaMusicPause
smpsNoteFill → smpsNoteTimeout

Make same changes to _smps2asm_inc.asm, and add backward-compatibility wrappers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment