fix: show images on cluck dashboard via proxying images through cluck server #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rutmanz
reviewed
Jun 28, 2024
| @@ -29,6 +29,45 @@ router.get('/dash/image', async (req, res, next) => { | |||
| next(e) | |||
| } | |||
| }) | |||
| router.get('/dash/imageproxy', async (req, res, next) => { | |||
There was a problem hiding this comment.
Why not return the image blob from /dash/image directly? It already has the image url and it also lets you avoid making user-specified fetch requests server-side
There was a problem hiding this comment.
🤯 Great idea. What if you or the app sw managers gave that task to a new sw person so they can learn how cluck works for when you are gone?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also, someones gotta change '20 Beaverton TC' to '20 To Beaverton TC' in trimet.ts to get the beaverton trimet working again. they changed the short sign for some reason :)