Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using $CONFIG_VALUES_JSON_PATCH_PATH in someModule hooks but it not work #536

Closed
wuxiaocheng0506 opened this issue Dec 6, 2024 · 2 comments · Fixed by #557
Closed

using $CONFIG_VALUES_JSON_PATCH_PATH in someModule hooks but it not work #536

wuxiaocheng0506 opened this issue Dec 6, 2024 · 2 comments · Fixed by #557
Assignees

Comments

@wuxiaocheng0506
Copy link

I'm try to appned some JSON patch to $CONFIG_VALUES_JSON_PATCH_PATH in someModule's hooks, but after all hooks done, the ConfigMap/addon-operator values not be updated.

such as:

# /modules/001-some-module/hooks/hook.sh

if [[ $binding == "beforeHelm" ]]; then
  ...
  cat > $CONFIG_VALUES_JSON_PATCH_PATH <<EOF
    [{"op":"add", "path":"/someModule/param11", "value":"value11"}]
EOF
fi

and then

kubectl -n test get cm/addon-operator -o=yaml

but the values of configmap not updated.

Environment:

  • Addon-operator version: v1.5.3
  • Helm version: v3.10.3
  • Kubernetes version: v1.24.17
  • Installation type (kubectl apply, helm chart, etc.):
@miklezzzz
Copy link
Contributor

I was able to reproduce the issue, will look into it. Thanks for the report.

@miklezzzz
Copy link
Contributor

should be fixed in #557

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants