generate random relay key when none found #337
Merged
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faheelsattar
requested review from
dvush,
ZanCorDX,
ferranbt and
liamaharon
as code owners
ferranbt
reviewed
Jan 4, 2025
| } | ||
| warn!("No relay secret key provided. A random key will be generated."); | ||
| let secret_key = SecretKey::new(&mut rand::thread_rng()); | ||
| hex::encode(secret_key.secret_bytes()) |
There was a problem hiding this comment.
Do not convert to string to convert back to BLSBlockSigner
There was a problem hiding this comment.
passing SecretKey directly now
ferranbt
reviewed
Jan 4, 2025
ferranbt
reviewed
Jan 4, 2025
ferranbt
reviewed
Jan 4, 2025
Benchmark results for
|
| Date (UTC) | 2025-01-06T08:32:25+00:00 |
| Commit | 2e1d03cc7a2fe339b80caaff12735f07b3877f03 |
| Base SHA | 026df71fdf2c8c6f6740682b6358d02f0e14bc09 |
Significant changes
| Benchmark | Mean | Status |
|---|---|---|
| gather_nodes_clone | -16.46% | Performance has improved. |
| gather_nodes_empty_account | 3.78% | Performance has degraded. |
ferranbt
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Generates a random relay secret key when none is set
Closes #333
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test