Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: cross python wheel #662

Merged
merged 4 commits into from
Dec 14, 2024
Merged

Conversation

xslingcn
Copy link
Contributor

We can build a single python wheel for all supported python versions.

  • Remove the python versions matrix
  • Add --py-limited-api config in building commands

@xslingcn
Copy link
Contributor Author

xslingcn commented Dec 13, 2024

Can't test it now because the self-hosted runner is not set up in github actions at the moment.

runs-on: [self-hosted]
steps:
- uses: actions/checkout@v4
with:
submodules: true

@yzh119
Copy link
Collaborator

yzh119 commented Dec 13, 2024

Hi @youkaichao @comaniac , we are using --py-limited-api to build wheels for more python versions, do you think we did it correctly?

@xslingcn
Copy link
Contributor Author

xslingcn commented Dec 14, 2024

Hi @youkaichao @comaniac , we are using --py-limited-api to build wheels for more python versions, do you think we did it correctly?

The usage of Limited API is not very well documented for setuptools, but I've found some references:
pypa/packaging.python.org#1376
pytorch/pytorch#138088

@youkaichao
Copy link

Looks reasonable. can you test it?

@xslingcn xslingcn changed the title [WIP] ci: cross python wheel ci: cross python wheel Dec 14, 2024
@xslingcn xslingcn marked this pull request as ready for review December 14, 2024 09:15
Copy link
Collaborator

@yzh119 yzh119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's first check whether this works on nightly wheels.

@yzh119 yzh119 merged commit b1b1fb8 into flashinfer-ai:main Dec 14, 2024
@zhyncs zhyncs mentioned this pull request Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants