Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Setup CODEOWNERS file #1665

Open
tormath1 opened this issue Mar 3, 2025 · 1 comment
Open

[RFE] Setup CODEOWNERS file #1665

tormath1 opened this issue Mar 3, 2025 · 1 comment
Labels
kind/feature A feature request

Comments

@tormath1
Copy link
Contributor

tormath1 commented Mar 3, 2025

Current situation

When an external contributor or a maintainer opens a PR, one needs to manually set flatcar-maintainers as reviewer.

Impact

  1. It's easy to miss
  2. You have to know about the different GitHub teams (nebraska-maintainers, flatcar-maintainers, etc.)

Ideal future situations

There is CODEOWNERS file to automatically set a GitHub team as a reviewer of the PR for a given repo.

Implementation options

Additional information

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#about-code-owners

@John15321
Copy link
Member

John15321 commented Mar 3, 2025

If the CODEOWNERS file is static, maybe with each commit to the main branch, we could have a job that makes sure that the people present in MAINTAINERS.md are also present in CODEOWNERS and if needed appends them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A feature request
Projects
Status: 📝 Needs Triage
Development

No branches or pull requests

2 participants