-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discord is staying on version 0.0.74 until the file chooser portal issue is fixed #483
Comments
Version 0.0.76 (released today) remains broken. |
hey, is there a way to upgrade despite this issue? |
Right now the only way to achieve that is by building/packaging a newer version of Discord on your own machine. |
Despite having added the "SKIP_HOST_UPDATE" option to |
@winkelnp I'm not experiencing the issue you're describing here... Can you share the output of |
Output of `flatpak run com.discordapp.Discord`
|
Uhh, there seems to be something really wrong with your Flatpak/Discord installation here. Your logs are saying that Discord is installed to I'm not sure if you did that intentionally (e.g. through symlinks or Flatpak overrides), but I'm afraid that's an unsupported setup. If you're willing to delete all your local Discord user data and start from scratch, you can try deleting the entire |
I have no idea what is happening there, I've now deleted the directory, reinstalled Discord etc, but somehow it still says that. I've removed any and all overrides, it should all be running as stock, but is still giving me that message. |
Yeah, I'm not sure what's going on there either, especially because I think the only way to change |
Discord 0.0.77 (released today) still ships Electron 32.2.2, and so the file chooser portal remains broken. |
Discord 0.0.78 (released today) now ships Electron 32.2.7, but the file chooser portal is still broken on that version. |
Discord 0.0.79 (released today) still ships Electron 32.2.7, and so the file chooser portal remains broken. |
Electron has a "workaround" that could allow fixing this, however it has only landed into Electron 34 as of the time of writing: electron/electron#44426 There does appear to be a chance it will be backported, but it's not guaranteed at this stage. On the xdg-desktop-portal side the required version by Electron 32 is expected "in the coming months". |
Yeah, right now the hope is that they backport that fix to the 33.x and 32.x branches, but so far no one has sent a pull request. But I think Discord maintains its own Electron fork (here), so it might be worthwhile to ask them to patch that into their fork. |
It seems like Discord now blocks these older Versions, thus it has stopped working as the flatpak Version :/ |
0.0.74 is still working just fine for me. What specific problems are you having? |
Discord got updated today and then it flashed for a second "Outdated Version". Now whenever i try to open it, there is a Discord Window and a grey background. No error messages, no Logs nothing! Tried to clear all cache and reinstall it, same Situation.. |
Discord shouldn't even be trying to update itself because we disable that functionality with a script. Can you try to reset Discord and try to set it up again? Before proceeding, please be aware that this will remove all your local Discord data: # kill any Discord instance (if any)
$ flatpak kill com.discordapp.Discord
# update all your flatpaks first, just in case
$ flatpak update
# remove all Discord data
$ rm -rf ~/.var/app/com.discordapp.Discord
# run Discord again
$ flatpak run com.discordapp.Discord If you still don't get a working Discord client after that, please share the output of the |
I'd had the same issue as @Subwaytime so I tried to do this. Discord tried to update itself again and failed to properly launch, same as before.
I didn't post the entire output because most of it was variations of |
Having the entire log is better to avoid ambiguity, but I'm guessing these messages are the result of Electron crashing and not being able to install the updates:
It seems that there's an upstream issue about it, but with no actual solution yet. Can you try launching Discord with
|
Oddly enough, running it through terminal makes Discord work. |
So this didn't work, the same issue kept happening (even after going through the whole process including But I tried again a couple minutes ago and now it works without any launch argument. Not quite sure what changed. |
I have no idea either. Maybe that crash is completely random (which would explain why it hasn't been fixed yet). Hopefully it doesn't happen again... |
Discord 0.0.80 (released today) still ships Electron 32.2.7, and so the file chooser portal remains broken. |
Looks like someone has started a manual backport to Electron 32: electron/electron#45193 Hopefully this lands before the next Discord update and they push to this version of Electron 32 |
Looks like it's been merged in now, guess keep our eyes out for v32.2.9 (or v32.3.0 depending) As of now the only released Electron version with the fix is v34.0.0. |
I wanted to open a pull request with the fix, but it looks like Discord is no longer using this fork. The last commit there is several months old. We will probably just have to wait and see. |
Discord 0.0.81 (released today) still ships Electron 32.2.7, so the file chooser portal remains broken. |
Looks like Electron 32.3.0 has released a little bit ago with the fix included. Hopefully Discord bumps their Electron version for the next release and we can get some updates again. |
Looking into another issue I was having with Visual Studio code, I've found that there is another issue in Electron 32.3.0 (and any other current Electron version) where pasting no longer works if controlled by the application: microsoft/vscode#238609 I'm unsure if this will effect Discord outside of the "context menu" paste option or not. |
Discord 0.0.82 (released today) still ships Electron 32.2.7, so the file chooser portal remains broken.
I just tested copying and pasting in 0.0.82, using both the keyboard and Discord's own context menu, and thankfully it seems to be working just fine still. |
Discord 0.0.83 (released today) still ships Electron 32.2.7, so the file chooser portal remains broken. |
Discord 0.0.84 (released today) still ships Electron 32.2.7, so the file chooser portal remains broken. This version was released just one day after 0.0.83, and I suspect it was only done to fix an unrelated issue with glibc 2.41. |
This comment has been minimized.
This comment has been minimized.
Discord 0.0.85 (released today) still ships Electron 32.2.7, so the file chooser portal remains broken. |
This comment has been minimized.
This comment has been minimized.
Bad news, everyone. Discord 0.0.86 just got released, and they've finally updated their Electron version to 33.4.0 from 32.2.7. The problem is, the file chooser portal bug has only been fixed in versions 32.3.0 and 34.0.0, while the fix for 33.x is still being worked on... 😢 And now I'm really conflicted: On the one hand, if I decide to just update our Flatpak package to 0.0.86, it will break a feature that was previously working perfectly for everyone. On the other hand, if we stay on 0.0.74, either until Discord devs update to Electron 34, or until Electron devs land the fix for Electron 33, this will likely keep us from updating Discord for months, again. And I know Wayland users have been eagerly waiting for streaming/recording support added in Discord 0.0.80. I think I will first try to send an email to Discord devs, explaining this whole situation, and ultimately asking them to consider updating to Electron 34 (which has the portal fix), or maybe help moving forward the portal fix for Electron 33.x... As usual, I'll keep you guys posted on any updates. |
I'm not trying to sound abrasive but it's kind of maddening that despite this Flatpak being marked as verified, the only way to maybe have Discord devs made aware of this is to have a maintainer resort to sending them emails. Some level of involvement from the organization (in this case, Discord) with the Flatpak repository should be mandatory for verified status. Regardless, hope your efforts bear fruits @guihkx . |
The "verified" flatpak marker should not be trusted for anything. It doesn't means the software dev is behind the flatpak builds. |
While I do believe that Discord’s verified badge on Flathub is subject to criticism — feel free to post your thoughts on issue #343, but please be respectful —, complaining about it here won't solve the issue at hand, so I kindly ask everyone to keep the discussion on topic. |
It appears there's some movement again on the backport of the fix to 33.x which is good at least. Honestly at this rate we might see xdg-desktop-portal 1.20 release before we see this merged and released on Electron's end and to get Discord updated to it 😂 So here's hoping you reaching out to Discord might get us bumped to 34.x so we won't have to wait. |
Hi, @klow-discord can you please share any timeline if available on when Discord might start to use Electron 34? |
Since I've been on Linux, I've always had to use Flatseal to allow this flatpak access to other folders for uploading. I just recently did it on canary. I think it will be fine if you allow the flatpak to update with a proper note on the page/this repo about using flatpeak until that's fixed. |
I see your point, but that's only necessary if you must use drag and drop (Electron bug: electron/electron#30650). If you use the file upload button from Discord's UI (or Ctrl+Shift+U), the file chooser portal gets used, which allows you to choose files from any location on your computer. But that's what's been broken since Discord 0.0.75... Anyway, I'm seeing all your feedback and I just opened a pull request that updates Discord to I think that enabling Wayland by default can be a breaking change, so testing and feedback are very welcome — especially if you're on Wayland with NVIDIA or Intel hardware. Those interested in this, are invited to install the test build, and then run Discord with:
Please leave any feedback (positive or negative) on the pull request. Thanks. |
Just as a heads up but xdg-desktop-portal 1.20 has released as of a couple days ago. UPDATE: xdg-desktop-portal 1.20 is now out on Arch. I've been running the test branch of the flatpak since yesterday and can confirm the file chooser dialog works perfectly fine again. |
It's done, Discord has been updated to 0.0.87. It will take a few hours before is finally available for everyone, though. Please note that Wayland support has not been enabled by default as originally planned, so users interested in that are still required to do that manually. Another important reminder is that the problem with the file chooser portal has not been fixed with that Discord update, so if you have trouble uploading files from specific locations, you can either: 1. Simply move that file to one of the allowed directories: |
This issue should serve as a reminder to people wondering why we might not update Discord to upcoming releases immediately:
Discord 0.0.75 started shipping Electron 32.2.2, a version that ended up breaking the file chooser portal, and therefore making it impossible for users to upload files to Discord in a regular manner (unless these files are stored in one of the whitelisted directories).
I personally think that file uploading is an important feature to stay broken like that for who-knows-how-long. For that reason, I decided to downgrade Discord to 0.0.74 and stay on that version until the problem is fixed.
I'm personally monitoring new stable Discord releases and will be testing them locally to make sure the portal issue is fixed before we release it for everyone.
The text was updated successfully, but these errors were encountered: